From: "Matthew Bell" <mwsb@operamail.com>
To: kai-germaschewski@uiowa.edu, mwsb@operamail.com
Cc: linux-parport@torque.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Obvious(ish): 3c515 should work if ISAPNP is a module.
Date: Sun, 15 Dec 2002 09:05:52 +0800 [thread overview]
Message-ID: <20021215010552.24545.qmail@operamail.com> (raw)
Oh bum. I had it that way originally, for that reason, then left for a while, wondered what I was doing and removed the 'superflous' bit.
+#if defined(CONFIG_ISAPNP) || (defined (MODULE) && defined (CONFIG_ISAPNP_MODULE))
Matthew Bell
----- Original Message -----
From: Kai Germaschewski <kai-germaschewski@uiowa.edu>
Date: Sat, 14 Dec 2002 17:11:49 -0600 (CST)
To: Matthew Bell <mwsb@operamail.com>
Subject: Re: [PATCH] Obvious(ish): 3c515 should work if ISAPNP is a module.
> On Sun, 15 Dec 2002, Matthew Bell wrote:
>
> > This is valid for at least 2.4.20 and earlier; it works for me, and I
> > can't see any exceptional reason why it shouldn't work when ISAPNP is a
> > module.
>
> > --- linux-2.4.19.orig/drivers/net/3c515.c 2002-02-25 19:37:59.000000000 +0000
> > +++ linux-2.4.19/drivers/net/3c515.c 2002-08-03 18:24:05.000000000 +0100
> > @@ -370,7 +370,7 @@
> > { "Default", 0, 0xFF, XCVR_10baseT, 10000},
> > };
> >
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || defined (CONFIG_ISAPNP_MODULE)
> > static struct isapnp_device_id corkscrew_isapnp_adapters[] = {
> > { ISAPNP_ANY_ID, ISAPNP_ANY_ID,
> > ISAPNP_VENDOR('T', 'C', 'M'), ISAPNP_FUNCTION(0x5051),
> [...]
>
> It's really only obvious*ish*: If isapnp is a module but 3c515 built-in,
> you'll get link errors. The real fix for this is to do
>
> +#ifdef __ISAPNP__
>
> which will get all cases right.
>
> --Kai
>
>
--
_______________________________________________
Get your free email from http://mymail.operamail.com
Powered by Outblaze
next reply other threads:[~2002-12-15 0:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-15 1:05 Matthew Bell [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-14 20:12 [PATCH] Obvious(ish): 3c515 should work if ISAPNP is a module Matthew Bell
2002-12-14 23:11 ` Kai Germaschewski
2002-12-15 0:45 ` Zwane Mwaikambo
2002-12-15 0:55 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021215010552.24545.qmail@operamail.com \
--to=mwsb@operamail.com \
--cc=kai-germaschewski@uiowa.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@torque.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox