From: Jens Axboe <axboe@suse.de>
To: Robert Love <rml@tech9.net>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove error message on illegal ioctl
Date: Mon, 16 Dec 2002 10:16:15 +0100 [thread overview]
Message-ID: <20021216091615.GQ11892@suse.de> (raw)
In-Reply-To: <1039832542.5305.455.camel@phantasy>
On Fri, Dec 13 2002, Robert Love wrote:
> This error message is uber annoying and needs to go. Non-root can flood
> the console with this junk on invalid SCSI CD-ROM ioctl(),
> and that is exactly what gnome-cd does.
>
> An illegal ioctl() returns an error to the program. That is
> sufficient - we do not need KERN_ERROR warnings all over the place.
> Especially when any user can cause them at any rate.
>
> This patch, against 2.5.51, removes the message. Linus, please
> apply.
Vetoed. That particular function is also used for generic command passed
down from the uniform cdrom layer, and it's indeed very handy to see
errors if they occur from there.
Your non-root user still has to be able to open the cdrom.
--
Jens Axboe
next prev parent reply other threads:[~2002-12-16 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-14 2:22 [PATCH] remove error message on illegal ioctl Robert Love
2002-12-16 9:16 ` Jens Axboe [this message]
2002-12-16 9:39 ` Linus Torvalds
2002-12-16 11:56 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2002-12-11 5:56 Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021216091615.GQ11892@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox