[PATCH] remove error message on illegal ioctl

[PATCH] remove error message on illegal ioctl

[Robert Love]

Linus is away so I am just throwing this out on lkml..

This error message is uber annoying and needs to go.  Non-root can flood
the console with this junk on invalid SCSI CD-ROM ioctl(), and that is
exactly what gnome-cd does.

An illegal ioctl() returns an error to the program.  That is sufficient
- we do not need KERN_ERROR warnings all over the place.  Especially
when any user can cause them at any rate.

This patch, against 2.5.51, removes the message.

	Robert Love

 drivers/scsi/sr_ioctl.c |    3 ---
 1 files changed, 3 deletions(-)


diff -urN linux-2.5.51-mm1/drivers/scsi/sr_ioctl.c linux/drivers/scsi/sr_ioctl.c
--- linux-2.5.51-mm1/drivers/scsi/sr_ioctl.c	2002-12-10 17:45:03.000000000 -0500
+++ linux/drivers/scsi/sr_ioctl.c	2002-12-11 00:44:24.000000000 -0500
@@ -156,9 +156,6 @@
 			err = -ENOMEDIUM;
 			break;
 		case ILLEGAL_REQUEST:
-			if (!cgc->quiet)
-				printk(KERN_ERR "%s: CDROM (ioctl) reports ILLEGAL "
-				       "REQUEST.\n", cd->cdi.name);
 			err = -EIO;
 			if (SRpnt->sr_sense_buffer[12] == 0x20 &&
 			    SRpnt->sr_sense_buffer[13] == 0x00)

[PATCH] remove error message on illegal ioctl

[Robert Love]

This error message is uber annoying and needs to go.  Non-root can flood
the console with this junk on invalid SCSI CD-ROM ioctl(),
and that is exactly what gnome-cd does.

An illegal ioctl() returns an error to the program.  That is
sufficient - we do not need KERN_ERROR warnings all over the place.
Especially when any user can cause them at any rate.

This patch, against 2.5.51, removes the message.  Linus, please
apply.

	Robert Love

 drivers/scsi/sr_ioctl.c |    3 ---
 1 files changed, 3 deletions(-)


diff -urN linux-2.5.51/drivers/scsi/sr_ioctl.c linux/drivers/scsi/sr_ioctl.c
--- linux-2.5.51/drivers/scsi/sr_ioctl.c	2002-12-10 17:45:03.000000000 -0500
+++ linux/drivers/scsi/sr_ioctl.c	2002-12-11 00:44:24.000000000 -0500
@@ -156,9 +156,6 @@
 			err = -ENOMEDIUM;
 			break;
 		case ILLEGAL_REQUEST:
-			if (!cgc->quiet)
-				printk(KERN_ERR "%s: CDROM (ioctl) reports ILLEGAL "
-				       "REQUEST.\n", cd->cdi.name);
 			err = -EIO;
 			if (SRpnt->sr_sense_buffer[12] == 0x20 &&
 			    SRpnt->sr_sense_buffer[13] == 0x00)

Re: [PATCH] remove error message on illegal ioctl

[Jens Axboe]

On Fri, Dec 13 2002, Robert Love wrote:
> This error message is uber annoying and needs to go.  Non-root can flood
> the console with this junk on invalid SCSI CD-ROM ioctl(),
> and that is exactly what gnome-cd does.
> 
> An illegal ioctl() returns an error to the program.  That is
> sufficient - we do not need KERN_ERROR warnings all over the place.
> Especially when any user can cause them at any rate.
> 
> This patch, against 2.5.51, removes the message.  Linus, please
> apply.

Vetoed. That particular function is also used for generic command passed
down from the uniform cdrom layer, and it's indeed very handy to see
errors if they occur from there.

Your non-root user still has to be able to open the cdrom.

-- 
Jens Axboe

Re: [PATCH] remove error message on illegal ioctl

[Linus Torvalds]

On Mon, 16 Dec 2002, Jens Axboe wrote:
>
> Your non-root user still has to be able to open the cdrom.

Why not just make this all use the "quiet" flag, and make the ioctl's
always set it. That's what it's there for.

		Linus

Re: [PATCH] remove error message on illegal ioctl

[Jens Axboe]

On Mon, Dec 16 2002, Linus Torvalds wrote:
> 
> 
> On Mon, 16 Dec 2002, Jens Axboe wrote:
> >
> > Your non-root user still has to be able to open the cdrom.
> 
> Why not just make this all use the "quiet" flag, and make the ioctl's
> always set it. That's what it's there for.

Yes that would be fine. I just don't want uniform packets to be silently
dropped, that makes debugging a problem with a drive pretty much
impossible.

-- 
Jens Axboe