From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@codemonkey.org.uk>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] PCI: kill pdev_enable_device()
Date: Tue, 17 Dec 2002 19:52:50 -0500 [thread overview]
Message-ID: <20021218005250.GA27607@gtf.org> (raw)
In-Reply-To: <20021218004226.GA3204@suse.de>
On Wed, Dec 18, 2002 at 12:42:26AM +0000, Dave Jones wrote:
> On Tue, Dec 17, 2002 at 05:31:57PM -0500, Jeff Garzik wrote:
> > Ivan Kokshaysky wrote:
> > >- So, if we don't touch the PCI command registers, there is no point in
> > > using pdev_enable_device(). Most drivers properly use
> > > pci_enable_device() anyway.
> > Not only that, a driver _should_ be calling pci-enable-device, it's an
> > API requirement. J Random Driver should have a good reason _not_ to
> > call pci_enable_device() ...
>
> What about the xircom issue that was discussed in the last days ?
> Sounds like the solution isn't a full on pci_enable_device() as
> pcmcia 'knows better than us' at that stage aparently.
The solution in the driver is almost always pci_enable_device().
That recent issue was related to subsystem code not driver code;
for that specific situation, you are absolutely right:
pci_enable_device is not the right thing to do.
Jeff
next prev parent reply other threads:[~2002-12-18 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-17 17:19 [patch 2.5] PCI: kill pdev_enable_device() Ivan Kokshaysky
2002-12-17 22:31 ` Jeff Garzik
2002-12-18 0:42 ` Dave Jones
2002-12-18 0:52 ` Jeff Garzik [this message]
2002-12-18 10:11 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021218005250.GA27607@gtf.org \
--to=jgarzik@pobox.com \
--cc=davej@codemonkey.org.uk \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox