Re: ALSA update

Greg KH
2002-12-20T00:22:25Z

On Thu, Dec 19, 2002 at 01:18:10PM +0100, Jaroslav Kysela wrote:
> On Thu, 19 Dec 2002, Takashi Iwai wrote:
>
> > At Wed, 18 Dec 2002 22:51:27 +0300 (MSK),
> > Ruslan U. Zakirov <cubic@miee.ru> wrote:
> > >
> > > Hello, Jaroslav and All.
> > > How about other changes in new 2.5 kernel, like new PnP layer (Adam Belay)
> > > or changes with module & boot params (Rusty Russel)? There are now some
> > > changes in 2.5.52 kernel in sound/isa/opl3sa2.c that make this driver not
> > > compatible with other kernels. May be it's better split your tree in
> > > several trees for each version of kernels?
> >
> > if possible, we'll build up some wrapper for 2.4 on alsa-driver (not
> > the codebase for 2.5) tree. if not possible, yes, splitting to two
> > trees would be reasonable for such big changes...
> >
> > thanks for noticing this issue. i'll check them now.
>
> I just removed the complete callback redefinitions from the 2.5 tree,
> but we still have three small OLD_USB sections (mainly commenting 2.5
> code which 2.4 code requires to override). Hopefully, it's quite reasonable.
> What do you think, Greg?

In the end, whatever is easiest for you do to, as I'm not the one who
has to maintain the code :)

That being said, the smaller the number of #ifdefs, the better.
Personally I would just have two different trees, but that's just me...

thanks,

greg k-h