From: Vojtech Pavlik <vojtech@suse.cz>
To: george anzinger <george@mvista.com>
Cc: Bjorn Helgaas <bjorn_helgaas@hp.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] joydev: fix HZ->millisecond transformation
Date: Fri, 20 Dec 2002 14:24:43 +0100 [thread overview]
Message-ID: <20021220142443.A26184@ucw.cz> (raw)
In-Reply-To: <3E02F3EE.C1367073@mvista.com>; from george@mvista.com on Fri, Dec 20, 2002 at 02:41:50AM -0800
On Fri, Dec 20, 2002 at 02:41:50AM -0800, george anzinger wrote:
> Bjorn Helgaas wrote:
> >
> > * fix a problem with HZ->millisecond transformation on
> > non-x86 archs (from 2.5 change by vojtech@suse.cz)
> >
> > Applies to 2.4.20.
> >
> > diff -Nru a/drivers/input/joydev.c b/drivers/input/joydev.c
> > --- a/drivers/input/joydev.c Mon Dec 16 12:16:32 2002
> > +++ b/drivers/input/joydev.c Mon Dec 16 12:16:32 2002
> > @@ -50,6 +50,8 @@
> > #define JOYDEV_MINORS 32
> > #define JOYDEV_BUFFER_SIZE 64
> >
> > +#define MSECS(t) (1000 * ((t) / HZ) + 1000 * ((t) % HZ) / HZ)
> Uh...
> ^^^^^^^^^^^^^^^^
> by definition this is zero, is it not?
No, both parts of the equaition can be nonzero.
Though it might be easier to say (1000 * t) / HZ, now that I think about
it.
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-12-20 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-16 19:27 [PATCH] joydev: fix HZ->millisecond transformation Bjorn Helgaas
2002-12-20 10:41 ` george anzinger
2002-12-20 13:24 ` Vojtech Pavlik [this message]
2002-12-20 14:52 ` Joe Korty
2002-12-20 17:24 ` george anzinger
2002-12-20 17:35 ` Vojtech Pavlik
2002-12-20 18:16 ` george anzinger
2002-12-21 9:18 ` Vojtech Pavlik
2002-12-21 16:46 ` george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021220142443.A26184@ucw.cz \
--to=vojtech@suse.cz \
--cc=bjorn_helgaas@hp.com \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox