From: William Lee Irwin III <wli@holomorphy.com>
To: Andreas Schwab <schwab@suse.de>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
bjorn_helgaas@hp.com
Subject: Re: [PATCH] Fix CPU bitmask truncation
Date: Fri, 20 Dec 2002 09:12:43 -0800 [thread overview]
Message-ID: <20021220171243.GD9704@holomorphy.com> (raw)
In-Reply-To: <je7ke4yje3.fsf@sykes.suse.de>
William Lee Irwin III <wli@holomorphy.com> writes:
|> ===== include/linux/init_task.h 1.19 vs edited =====
|> --- 1.19/include/linux/init_task.h Sun Sep 29 07:02:55 2002
|> +++ edited/include/linux/init_task.h Fri Dec 20 02:22:04 2002
|> @@ -63,7 +63,7 @@
|> .prio = MAX_PRIO-20, \
|> .static_prio = MAX_PRIO-20, \
|> .policy = SCHED_NORMAL, \
|> - .cpus_allowed = -1, \
|> + .cpus_allowed = ~0UL, \
On Fri, Dec 20, 2002 at 01:17:24PM +0100, Andreas Schwab wrote:
> This is useless. Assigning -1 to any unsigned type is garanteed to give
> you all bits one, and with two's complement this also holds for any signed
> type.
Not so on all gcc versions. The rest of the world can figure out what
to do about the versions that do not.
Bill
next prev parent reply other threads:[~2002-12-20 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-16 19:13 [PATCH] Fix CPU bitmask truncation Bjorn Helgaas
2002-12-20 10:30 ` William Lee Irwin III
2002-12-20 11:15 ` William Lee Irwin III
2002-12-20 17:00 ` Bjorn Helgaas
2002-12-25 21:43 ` Alan Cox
2002-12-25 21:54 ` Linus Torvalds
2002-12-20 12:17 ` Andreas Schwab
2002-12-20 17:12 ` William Lee Irwin III [this message]
2002-12-20 18:23 ` Jeremy Fitzhardinge
2002-12-20 20:00 ` Andreas Schwab
2002-12-20 22:57 ` Anton Blanchard
2002-12-20 23:36 ` William Lee Irwin III
2002-12-20 23:42 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021220171243.GD9704@holomorphy.com \
--to=wli@holomorphy.com \
--cc=bjorn_helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox