From: Pavel Machek <pavel@suse.cz>
To: Ducrot Bruno <poup@poupinou.org>
Cc: Pavel Machek <pavel@suse.cz>,
"Grover, Andrew" <andrew.grover@intel.com>,
acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ACPI] [PATCH] acpi_wakeup fixes
Date: Sat, 21 Dec 2002 13:01:02 +0100 [thread overview]
Message-ID: <20021221120101.GA1371@zaurus> (raw)
In-Reply-To: <20021217202142.GB1012@poup.poupinou.org>
Hi!
> @@ -41,7 +41,7 @@
> cmpl _0x12345678, %eax
> jne bogus_real_magic
>
> -#if 1
> +#if 0
> lcall _0xc000,_3
> #endif
> #if 0
We should make this runtime configurable...
Anyway disabling this is probably right.
> @@ -69,8 +69,12 @@
>
> movl real_save_cr0 - wakeup_code, %eax
> movl %eax, %cr0
> +
> + # flush the prefetch queue.
> jmp 1f
> +1: jmp 1f
> 1:
Is this really neccessary? One jump should be
ok...
> @@ -160,11 +164,12 @@
> ALIGN
>
>
> -.org 0x2000
> +.org 0x800
> wakeup_stack:
> -.org 0x3000
> +.org 0x900
> ENTRY(wakeup_end)
> -.org 0x4000
> +# .org 0x1000
> + .align 4096
Kill the comment, otherwise ok.
> wakeup_pmode_return:
> movl ___KERNEL_DS, %eax
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
next prev parent reply other threads:[~2002-12-23 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-17 20:21 [PATCH] acpi_wakeup fixes Ducrot Bruno
2002-12-21 12:01 ` Pavel Machek [this message]
2003-01-14 17:56 ` [ACPI] acpi_wakeup fixes: Patch? P. Christeas
2003-01-14 19:52 ` Ducrot Bruno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021221120101.GA1371@zaurus \
--to=pavel@suse.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=andrew.grover@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=poup@poupinou.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).