From: James Bottomley <James.Bottomley@steeleye.com>
To: Kai Germaschewski <kai-germaschewski@uiowa.edu>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com
Subject: [PATCH] fix bug in scripts/kallsyms.c
Date: Sat, 21 Dec 2002 12:05:05 -0600 [thread overview]
Message-ID: <200212211805.gBLI55c03659@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
kallsyms.c generates the symbol table in a .S file using the assembler .string
macro. Unfortunately, the .string macro is implemented in a platform specific
way (it may or may not zero terminate the string). On parisc, it doesn't zero
terminate, so the symbol table search doesn't work.
The solution is to replace .string with .asciz which is guaranteed to do the
correct thing on all platforms.
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 368 bytes --]
===== scripts/kallsyms.c 1.2 vs edited =====
--- 1.2/scripts/kallsyms.c Thu Dec 5 13:57:11 2002
+++ edited/scripts/kallsyms.c Sat Dec 21 11:43:11 2002
@@ -128,7 +128,7 @@
if (table[i].addr == last_addr)
continue;
- printf("\t.string\t\"%s\"\n", table[i].sym);
+ printf("\t.asciz\t\"%s\"\n", table[i].sym);
last_addr = table[i].addr;
}
printf("\n");
reply other threads:[~2002-12-21 17:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200212211805.gBLI55c03659@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=kai-germaschewski@uiowa.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox