public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Erik Andersen <andersen@codepoet.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: bcollins@debian.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix 2.4.x ieee1394
Date: Sun, 22 Dec 2002 04:26:13 -0700	[thread overview]
Message-ID: <20021222112613.GA8743@codepoet.org> (raw)
In-Reply-To: <200212172033.gBHKX6A32611@hera.kernel.org>

On Tue Dec 17, 2002 at 04:14:22PM +0000, linux-kernel wrote:
> ChangeSet 1.901, 2002/12/17 14:14:22-02:00, bcollins@debian.org
> 
> 	[PATCH] Linux1394 Firewire
> 	
> 	Syncs to our Linux-2.4 branch. Mostly bug fixes. I'll start sending more
> 	frequent and mmore verbose patches.
> 
> 
> # This patch includes the following deltas:
> #	           ChangeSet	1.900   -> 1.901  
[-------------snip---------]
> diff -Nru a/drivers/ieee1394/Makefile b/drivers/ieee1394/Makefile
> --- a/drivers/ieee1394/Makefile	Tue Dec 17 12:33:07 2002
> +++ b/drivers/ieee1394/Makefile	Tue Dec 17 12:33:07 2002
> @@ -2,11 +2,8 @@
>  # Makefile for the Linux IEEE 1394 implementation
>  #
>  
> -O_TARGET := ieee1394drv.o
> -

After this change, firewire doesn't build for me when adding
1394 stuff directly into the kernel, i.e.

    CONFIG_IEEE1394=y
    CONFIG_IEEE1394_OHCI1394=m
    CONFIG_IEEE1394_SBP2=m
    CONFIG_IEEE1394_RAWIO=y

The top level kernel Makefile has:
    DRIVERS-$(CONFIG_IEEE1394) += drivers/ieee1394/ieee1394drv.o
but there is no longer a ieee1394drv.o target.  This patch fixes 
the problem.

--- linux/Makefile.orig	2002-12-21 14:32:42.000000000 -0700
+++ linux/Makefile	2002-12-21 19:59:00.000000000 -0700
@@ -153,7 +153,7 @@
 DRIVERS-$(CONFIG_FC4) += drivers/fc4/fc4.a
 DRIVERS-$(CONFIG_SCSI) += drivers/scsi/scsidrv.o
 DRIVERS-$(CONFIG_FUSION_BOOT) += drivers/message/fusion/fusion.o
-DRIVERS-$(CONFIG_IEEE1394) += drivers/ieee1394/ieee1394drv.o
+DRIVERS-$(CONFIG_IEEE1394) += drivers/ieee1394/ieee1394.o
 
 ifneq ($(CONFIG_CD_NO_IDESCSI)$(CONFIG_BLK_DEV_IDECD)$(CONFIG_BLK_DEV_SR)$(CONFIG_PARIDE_PCD),)
 DRIVERS-y += drivers/cdrom/driver.o

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

       reply	other threads:[~2002-12-22 11:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200212172033.gBHKX6A32611@hera.kernel.org>
2002-12-22 11:26 ` Erik Andersen [this message]
2002-12-22 14:01   ` [PATCH] fix 2.4.x ieee1394 Ben Collins
2002-12-29 15:38   ` Adrian Bunk
2002-12-29 16:44     ` Erik Andersen
2002-12-29 16:52       ` Ben Collins
2002-12-31 15:19         ` Kai Germaschewski
2002-12-29 17:43       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021222112613.GA8743@codepoet.org \
    --to=andersen@codepoet.org \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox