From: "J.A. Magallon" <jamagallon@able.es>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: Lista Linux-Kernel <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@hera.kernel.org>,
davem@redhat.com
Subject: Re: [BUG+PATCH] binfmt_elf::create_elf_tables changes u_platform without refill
Date: Sat, 28 Dec 2002 01:14:43 +0100 [thread overview]
Message-ID: <20021228001443.GE2079@werewolf.able.es> (raw)
In-Reply-To: <20021227235835.GA2079@werewolf.able.es>; from jamagallon@able.es on Sat, Dec 28, 2002 at 00:58:35 +0100
On 2002.12.28 J.A. Magallon wrote:
> Hi all...
>
[...]
> #if defined(__i386__) && defined(CONFIG_SMP)
> if(smp_num_siblings > 1)
> u_platform = u_platform - ((current->pid % 64) << 7);
> ///// So original u_platform with data is lost !!!
> #endif
> ...
[...]
>
> One question: why the 64 value ? Because linux supports 64 processors ?
> Why not just 2, because you have two siblings at most ?
>
Better, shouldn't this be NR_CPUS ? So you save half stack space on ia32,
or even more with CONFIG_NR_CPUS...
--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.1 (Cooker) for i586
Linux 2.4.21-pre2-jam1 (gcc 3.2.1 (Mandrake Linux 9.1 3.2.1-2mdk))
prev parent reply other threads:[~2002-12-28 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-27 23:58 [BUG+PATCH] binfmt_elf::create_elf_tables changes u_platform without refill J.A. Magallon
2002-12-28 0:14 ` J.A. Magallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021228001443.GE2079@werewolf.able.es \
--to=jamagallon@able.es \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@hera.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox