public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH][2.4-ac] VT8633 GART Support [RESEND] Corrected
  2002-12-31 16:18 [PATCH][2.4-ac] VT8633 GART Support [RESEND] Corrected Nathaniel Russell
@ 2002-12-31  4:23 ` Marc-Christian Petersen
  2002-12-31 13:19   ` Dave Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Marc-Christian Petersen @ 2002-12-31  4:23 UTC (permalink / raw)
  To: Nathaniel Russell, alan; +Cc: linux-kernel

On Tuesday 31 December 2002 17:18, Nathaniel Russell wrote:

Hi Nathaniel,

> The first patch i sent to the list was wroung becaue i miss typed out the
> PCI_DEVICE... it was supposed to be PCI_DEVICE_ID_VIA_8633_0 pci id is
> 0x3091
> Well here is the complete fixed and correct version of my patch.
> I'm sorry about all the hassle.
> Please apply the corrected patch to 2.4.20-ac2
> Marc it should complete compile this time around, that is really weird,
> Thank you though.
> Nathaniel
> CC me at reddog83@chartermi.net
shouldn't this be exactly 8633_1 ? Assuming this is a AGP patch and: 
http://pciids.sourceforge.net/iii/?m=1&i=1106b091

tells the same, 8633_1 :)

ciao, Marc

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.4-ac] VT8633 GART Support [RESEND] Corrected
  2002-12-31  4:23 ` Marc-Christian Petersen
@ 2002-12-31 13:19   ` Dave Jones
  0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2002-12-31 13:19 UTC (permalink / raw)
  To: Marc-Christian Petersen; +Cc: Nathaniel Russell, alan, linux-kernel

On Tue, Dec 31, 2002 at 05:23:57AM +0100, Marc-Christian Petersen wrote:
 > > The first patch i sent to the list was wroung becaue i miss typed out the
 > > PCI_DEVICE... it was supposed to be PCI_DEVICE_ID_VIA_8633_0 pci id is
 > > 0x3091
 > > Well here is the complete fixed and correct version of my patch.
 > shouldn't this be exactly 8633_1 ? Assuming this is a AGP patch and: 
 > http://pciids.sourceforge.net/iii/?m=1&i=1106b091
 > tells the same, 8633_1 :)

No. We match on host bridge, as thats where the magick bits we
need to frob live. The bits in the AGP bridge are usually set up
by the BIOS. When we do need to poke them too, we go looking for
it in the initialisation routine.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH][2.4-ac] VT8633 GART Support [RESEND] Corrected
@ 2002-12-31 16:18 Nathaniel Russell
  2002-12-31  4:23 ` Marc-Christian Petersen
  0 siblings, 1 reply; 3+ messages in thread
From: Nathaniel Russell @ 2002-12-31 16:18 UTC (permalink / raw)
  To: m.c.p, alan; +Cc: linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 431 bytes --]

The first patch i sent to the list was wroung becaue i miss typed out the
PCI_DEVICE... it was supposed to be PCI_DEVICE_ID_VIA_8633_0 pci id is
0x3091
Well here is the complete fixed and correct version of my patch.
I'm sorry about all the hassle.
Please apply the corrected patch to 2.4.20-ac2

Marc it should complete compile this time around, that is really weird,
Thank you though.
Nathaniel
CC me at reddog83@chartermi.net



[-- Attachment #2: Via VT8633 --]
[-- Type: TEXT/PLAIN, Size: 2085 bytes --]

diff -urN linux-ac/drivers/char/drm/drm_agpsupport.h~ linux-ac/drivers/char/drm/drm_agpsupport.h
--- linux-ac/drivers/char/drm/drm_agpsupport.h~	2002-12-20 02:01:06.000000000 -0500
+++ linux-ac/drivers/char/drm/drm_agpsupport.h	2002-12-20 02:18:57.000000000 -0500
@@ -283,6 +283,8 @@
 			break;
 		case VIA_APOLLO_PRO: 	head->chipset = "VIA Apollo Pro";
 			break;
+		case VIA_VT8633:	head->chipset =	"VIA Apollo Pro266";
+			break;
 
 		case SIS_GENERIC:	head->chipset = "SiS";           break;
 		case AMD_GENERIC:	head->chipset = "AMD";           break;
diff -urN linux-ac/drivers/char/drm-4.0/agpsupport.c~ linux-av/drivers/char/drm-4.0/agpsupport.c
--- linux-ac/drivers/char/drm-4.0/agpsupport.c~	2002-12-20 02:01:07.000000000 -0500
+++ linux-ac/drivers/char/drm-4.0/agpsupport.c	2002-12-20 02:15:09.000000000 -0500
@@ -281,6 +281,8 @@
 
 		case VIA_APOLLO_PRO: 	head->chipset = "VIA Apollo Pro";
 			break;
+		case VIA_VT8633:	head->chipset = "VIA Apollo Pro266";
+			break;
 		case SIS_GENERIC:	head->chipset = "SiS";           break;
 		case AMD_GENERIC:	head->chipset = "AMD";           break;
 		case AMD_IRONGATE:	head->chipset = "AMD Irongate";  break;
diff -urN linux-ac/drivers/char/agp/agpgart_be.c~ linux/drivers/char/agp/agpgart_be.c
--- linux-ac/drivers/char/agp/agpgart_be.c~	2002-12-20 02:01:05.000000000 -0500
+++ linux-ac/drivers/char/agp/agpgart_be.c	2002-12-20 02:03:51.000000000 -0500
@@ -4732,6 +4732,12 @@
 		"Via",
 		"Apollo Pro KT400",
 		via_generic_setup },
+	{ PCI_DEVICE_ID_VIA_8633_0,
+		PCI_VENDOR_ID_VIA,
+		VIA_VT8633,
+		"Via",
+		"Apollo Pro266",
+		via_generic_setup },
 	{ 0,
 		PCI_VENDOR_ID_VIA,
 		VIA_GENERIC,
diff -urN linux-ac/include/linux/agp_backend.h~ linux-ac/include/linux/agp_backend.h
--- linux-ac/include/linux/agp_backend.h~	2002-12-20 02:01:21.000000000 -0500
+++ linux-ac/include/linux/agp_backend.h	2002-12-20 02:05:55.000000000 -0500
@@ -61,6 +61,7 @@
 	VIA_APOLLO_KX133,
 	VIA_APOLLO_KT133,
 	VIA_APOLLO_KT400,
+	VIA_VT8633,
 	SIS_GENERIC,
 	AMD_GENERIC,
 	AMD_IRONGATE,

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-12-31 13:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-31 16:18 [PATCH][2.4-ac] VT8633 GART Support [RESEND] Corrected Nathaniel Russell
2002-12-31  4:23 ` Marc-Christian Petersen
2002-12-31 13:19   ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox