Re: [PATCH] generic device DMA (dma_pool update)

David Brownell
2002-12-31T17:17:34Z

James Bottomley wrote:
> How about the attached as the basis for a generic coherent memory pool
> implementation. It basically leverages pci/pool.c to be more generic, and
> thus makes use of well tested code.

I'd still rather have configuration completely eliminate that particular
pool allocator on the platforms (most, by volume) that don't need it,
in favor of the slab code ... which is not only well-tested, but also
has had a fair amount of cross-platform performance work done on it.

> Obviously, as a final tidy up, pci/pool.c should probably be moved to
> base/pool.c with compile options for drivers that want it.

I'd have no problems with making it even more generic, and moving it.

Though "compile options" doesn't sound right, unless you mean letting
arch-specific code choose whether to use that or the slab allocator.

- Dave