public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	ak@suse.de, davem@redhat.com, paulus@samba.org,
	rmk@arm.linux.org.uk
Subject: Re: [PATCH] Modules 3/3: Sort sections
Date: Wed, 1 Jan 2003 20:54:04 -0800	[thread overview]
Message-ID: <20030101205404.B30272@twiddle.net> (raw)
In-Reply-To: <20030102030044.D066C2C05E@lists.samba.org>; from rusty@rustcorp.com.au on Thu, Jan 02, 2003 at 02:00:27PM +1100

On Thu, Jan 02, 2003 at 02:00:27PM +1100, Rusty Russell wrote:
> +	/* Find .plt and .pltinit sections */

Typo.

> +/* Make empty sections for module_frob_arch_sections to expand. */
> +#ifdef MODULE
> +asm(".section .plt,\"aws\",@nobits; .align 3; .previous");
> +asm(".section .plt.init,\"aws\",@nobits; .align 3; .previous");

Should use "ax", do make the plt sections executable,
since the plt section contains code that branches.
Additionally, this will place the .plt section next
to .text, which improves icache usage, and minimizes
the branch distance.

Incidentally, why do we do strstr(name, ".init") instead
of strncmp(name, ".init", 5)?  Is there any particular
need for the .init to come at the end?


r~

  reply	other threads:[~2003-01-02  4:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02  3:00 [PATCH] Modules 3/3: Sort sections Rusty Russell
2003-01-02  4:54 ` Richard Henderson [this message]
2003-01-02  4:50   ` David S. Miller
2003-01-02  4:58     ` Richard Henderson
2003-01-02  5:15       ` David S. Miller
2003-01-02 10:35         ` Rusty Russell
2003-01-02 17:39         ` Alan Cox
2003-01-02  9:36       ` Arjan van de Ven
2003-01-02  9:37         ` Richard Henderson
2003-01-02 10:48   ` Rusty Russell
2003-01-06  9:25 ` Miles Bader
2003-01-06 10:17   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030101205404.B30272@twiddle.net \
    --to=rth@twiddle.net \
    --cc=ak@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rusty@rustcorp.com.au \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox