public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.54 kill module.h compiler warnings
Date: Fri, 03 Jan 2003 11:01:02 +1100	[thread overview]
Message-ID: <20030103042650.599842C09C@lists.samba.org> (raw)
In-Reply-To: Your message of "Thu, 02 Jan 2003 16:57:19 BST." <200301021557.QAA06497@harpo.it.uu.se>

In message <200301021557.QAA06497@harpo.it.uu.se> you write:
> Rusty,
> 
> Compiling kernel 2.5.54 with CONFIG_MODULES=n results in
> tons and tons of the following warnings:
> 
> include/linux/module.h:317: warning: statement with no effect
> include/linux/module.h:353: warning: statement with no effect
> 
> patch-2.5.54 changed *MOD_INC_USE_COUNT from macros to
> __deprecated functions, but also dropped the (void) casts
> in front of the try_module_get() calls. Without modules,
> try_module_get() is the constant 1, hence the warnings.
> 
> The patch below silences the warnings by adding back the
> missing (void) casts. Works for me.

I know, Christoph Hellwig changed this, and I believe RTH fixed it in
his merge with Linus.

Thanks!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

      parent reply	other threads:[~2003-01-03  4:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02 15:57 [PATCH] 2.5.54 kill module.h compiler warnings Mikael Pettersson
2003-01-02 22:54 ` Richard Henderson
2003-01-03  0:01 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030103042650.599842C09C@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox