public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@redhat.com>
To: Stephen Evanchik <evanchsa@clarkson.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.54] hermes: serialization fixes
Date: Fri, 3 Jan 2003 12:47:54 -0500	[thread overview]
Message-ID: <20030103124754.A16519@redhat.com> (raw)
In-Reply-To: <200301031239.29226.evanchsa@clarkson.edu>; from evanchsa@clarkson.edu on Fri, Jan 03, 2003 at 12:39:29PM -0500

On Fri, Jan 03, 2003 at 12:39:29PM -0500, Stephen Evanchik wrote:
> The hermes MAC controller module wasn't serializing BAP seek calls. This 
> caused an eventual Rx/Tx failure which equates tens of thousands of errors on 
> the wireless interface. A simple spinlock is used to keep things in line.
> 
> Any comments are appreciated, I don't believe this is the best solution, but 
> it is working well. Patches can be downloaded from here:

Why not put the spinlock/unlock inside hermes_bap_seek()?  Smaller, better 
contained and more readable.

		-ben

  reply	other threads:[~2003-01-03 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-03 17:39 [PATCH 2.5.54] hermes: serialization fixes Stephen Evanchik
2003-01-03 17:47 ` Benjamin LaHaise [this message]
2003-01-03 17:56   ` Stephen Evanchik
2003-01-06 17:40     ` Alexander Hoogerhuis
2003-01-06 18:36       ` Stephen Evanchik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030103124754.A16519@redhat.com \
    --to=bcrl@redhat.com \
    --cc=evanchsa@clarkson.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox