public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Richard Baverstock <beaver@gto.net>
Cc: Vojtech Pavlik <vojtech@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AGPGART for VIA vt8235, kernel 2.4.21-pre2
Date: Fri, 3 Jan 2003 17:43:23 +0000	[thread overview]
Message-ID: <20030103174323.GA10327@codemonkey.org.uk> (raw)
In-Reply-To: <20030103122216.39cedd3f.beaver@gto.net>

On Fri, Jan 03, 2003 at 12:22:16PM -0500, Richard Baverstock wrote:
 > > The vt8235 is the southbridge chip and that the AGP bridge is
 > > located in the northbridge, which most likely has a different
 > > number.
 > Sorry about that, thought the AGP was in the southbridge chip. I see
 > however that someone else has submitted a patch with the correct
 > naming conventions (It does seem to change between P4X333 and P4X400
 > however).

What exactly do you mean by 'it' ? The PCI device id ?

If they share the same device ID, then Bernhards patch is
really no better...

#define PCI_DEVICE_ID_VIA_P4X333       0x3168

In fact, P4X333 defines a chipset rather than a chip.
According to ..
http://www.viatech.com/en/apollo/p4x333.jsp and
http://www.viatech.com/en/apollo/p4x400.jsp ,
the northbridge is a VT8754 in both models, so the
correct define would seem to be PCI_DEVICE_ID_VIA_8754

Just to confirm, device 3168 is the host bridge in lspci output right?
And this does all work when you run a DRI application ?

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

  reply	other threads:[~2003-01-03 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02 19:53 [PATCH] AGPGART for VIA vt8235, kernel 2.4.21-pre2 Richard Baverstock
2003-01-03 16:16 ` Vojtech Pavlik
2003-01-03 17:22   ` Richard Baverstock
2003-01-03 17:43     ` Dave Jones [this message]
2003-01-03 18:00       ` Dave Jones
2003-01-03 18:24         ` Richard Baverstock
2003-01-03 18:13       ` Richard Baverstock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030103174323.GA10327@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=beaver@gto.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox