Re: Linux v2.5.54

Adrian Bunk
2003-01-02T15:00:26Z

On Wed, Jan 01, 2003 at 07:43:40PM -0800, Linus Torvalds wrote:

>...
> Summary of changes from v2.5.53 to v2.5.54
> ============================================
>...
> Christoph Hellwig <hch@lst.de>:
>...
> o include <linux/vfs.h> only in files actually needing it
>...

This change broke the compilation of fs/befs/linuxvfs.c:

<-- snip -->

...
gcc -Wp,-MD,fs/befs/.linuxvfs.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default -nostdinc
-iwithprefix include -DKBUILD_BASENAME=linuxvfs -DKBUILD_MODNAME=befs -c -o
fs/befs/linuxvfs.o fs/befs/linuxvfs.c
fs/befs/linuxvfs.c:15: linux/statfs.h: No such file or directory
...
fs/befs/linuxvfs.c: In function `befs_statfs':
fs/befs/linuxvfs.c:901: dereferencing pointer to incomplete type
fs/befs/linuxvfs.c:902: dereferencing pointer to incomplete type
fs/befs/linuxvfs.c:903: dereferencing pointer to incomplete type
...
make[2]: *** [fs/befs/linuxvfs.o] Error 1
make[1]: *** [fs/befs] Error 2
make: *** [fs] Error 2

<-- snip -->

I assume the following was intended?

--- linux-2.5.54/fs/befs/linuxvfs.c.old 2003-01-02 16:03:34.000000000 +0100
+++ linux-2.5.54/fs/befs/linuxvfs.c 2003-01-02 16:03:46.000000000 +0100
@@ -12,7 +12,7 @@
#include <linux/stat.h>
#include <linux/nls.h>
#include <linux/buffer_head.h>
-#include <linux/statfs.h>
+#include <linux/vfs.h>

#include "befs.h"
#include "btree.h"

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed