public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: jak@rudolph.ccur.com (Joe Korty)
To: akpm@digeo.com (Andrew Morton)
Cc: joe.korty@ccur.com (Joe Korty),
	sct@redhat.com, adilger@clusterfs.com, rusty@rustcorp.com.au,
	riel@conectiva.com.br, linux-kernel@vger.kernel.org, hch@sgi.com
Subject: Re: 2.4.21-pre2 stalls out when running unixbench
Date: Sat, 4 Jan 2003 21:58:33 -0500 (EST)	[thread overview]
Message-ID: <200301050258.CAA01487@rudolph.ccur.com> (raw)
In-Reply-To: <3E16C171.BFEA45AE@digeo.com> from "Andrew Morton" at Jan 04, 2003 03:11:45 AM

> With respect to the lockup problem: it is due to a non-atomic __set_bit()
> in the new buffer_attached() implementation.
> 
> Sure, we don't need atomic semantics for the BH_Attached bit because
> it is always read and modified under a global spinlock.  But *other*
> users of buffer_head.b_state do not run under that lock so the nonatomic
> RMW will stomp on their changes.   2.4.20 does not have this bug.
> 
> Here is a patch:


Hi Andrew,
The patch works (been running the unixbench subset for an hour now).
Your time and effort and very clear explanations are much appreciated.
Thanks,
Joe

  reply	other threads:[~2003-01-05  2:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-03 16:56 2.4.21-pre2 stalls out when running unixbench Joe Korty
2003-01-03 20:07 ` Andrew Morton
2003-01-03 20:30   ` Andrew Morton
2003-01-04  1:11     ` Joe Korty
2003-01-04 11:11       ` Andrew Morton
2003-01-05  2:58         ` Joe Korty [this message]
2003-01-06 12:10         ` Stephen C. Tweedie
2003-01-06 12:15           ` John Bradford
2003-01-06 13:20             ` Stephen C. Tweedie
2003-01-06 12:16           ` Andrew Morton
2003-01-06 13:23             ` Stephen C. Tweedie
2003-01-11  8:10         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200301050258.CAA01487@rudolph.ccur.com \
    --to=jak@rudolph.ccur.com \
    --cc=adilger@clusterfs.com \
    --cc=akpm@digeo.com \
    --cc=hch@sgi.com \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=rusty@rustcorp.com.au \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox