From: Dominik Brodowski <linux@brodo.de>
To: Andrew Morton <akpm@digeo.com>, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk
Subject: [PATCH] cpufreq: make gcc-2.91.66 happy (Was: Re: [PATCH 2.5.54] cpufreq: update timer notifier)
Date: Mon, 6 Jan 2003 23:34:43 +0100 [thread overview]
Message-ID: <20030106223443.GA1912@brodo.de> (raw)
In-Reply-To: <3E19F667.30043A97@digeo.com>
This patch updates the cpufreq #defines so that gcc-2.91.66 should
work happily with cpufreq.
On Mon, Jan 06, 2003 at 01:34:31PM -0800, Andrew Morton wrote:
> Dominik Brodowski wrote:
> >
> > +#else
> > +#define adjust_jiffies(...)
> > +#endif
>
> This will fail to compile on gcc-2.91.66. It's OK on 2.95.3.
>
> sparc64 requires a compiler of similar vintage (2.92.11), so
> I am trying to keep 2.91.66-on-x86 limping along so that breakage
> can be detected more easily.
>
> Please use
>
> #define adjust_jiffies(x...) do {} while (0)
>
> here. Or an empty inline, which tends to be nicer, because you
> still get argument type checking.
diff -ruN linux-original/kernel/cpufreq.c linux/kernel/cpufreq.c
--- linux-original/kernel/cpufreq.c 2003-01-06 23:27:59.000000000 +0100
+++ linux/kernel/cpufreq.c 2003-01-06 23:29:49.000000000 +0100
@@ -734,8 +734,8 @@
}
#else
-#define cpufreq_sysctl_init()
-#define cpufreq_sysctl_exit()
+#define cpufreq_sysctl_init() do {} while(0)
+#define cpufreq_sysctl_exit() do {} while(0)
#endif /* CONFIG_SYSCTL */
#endif /* CONFIG_CPU_FREQ_24_API */
@@ -946,7 +946,7 @@
loops_per_jiffy = cpufreq_scale(l_p_j_ref, l_p_j_ref_freq, ci->new);
}
#else
-#define adjust_jiffies(...)
+#define adjust_jiffies(x...) do {} while (0)
#endif
@@ -1131,6 +1131,6 @@
}
EXPORT_SYMBOL_GPL(cpufreq_restore);
#else
-#define cpufreq_restore()
+#define cpufreq_restore() do {} while (0)
#endif /* CONFIG_PM */
prev parent reply other threads:[~2003-01-06 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-06 13:55 [PATCH 2.5.54] cpufreq: update timer notifier Dominik Brodowski
2003-01-06 21:34 ` Andrew Morton
2003-01-06 22:34 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030106223443.GA1912@brodo.de \
--to=linux@brodo.de \
--cc=akpm@digeo.com \
--cc=cpufreq@www.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox