Re: [PATCH] configurable LOG_BUF_SIZE

[Tom Rini <trini@kernel.crashing.org>]

On Mon, Jan 06, 2003 at 02:04:52PM -0800, Randy.Dunlap wrote:
> On Mon, 6 Jan 2003, Tomas Szepe wrote:
> 
> | > [rddunlap@osdl.org]
> |
> | > | |---------------------------------------------------------------------------
> | > | | I'd probably be happier if the current one didn't even _ask_ the user (or|
> | > | | only asked the user if kernel debugging is enabled), and just silently   |
> | > | | defaulted to the normal values.                                          |
> | > | |---------------------------------------------------------------------------
> | >
> | Randy,
> |
> | this looks correct to me.  Maybe using if/endif instead of the two
> | 'depends on' would make the entry more explicit to the eye of a future
> | beholder.
> 
> Hey Tomas,
> 
> Thanks for looking and giving me your comments.
> 
> if/endif would be useful there, especially if there was also an 'else'
> available...

I think that's by design (if / else is limiting, which is why you have a
very flexible depends syntax).  That looks exactly like what we do in
arch/ppc/Kconfig.  Maybe a comment 'tho to make it more explicit what's
being done and why would be in order here however.

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/