include order for i2c-amd8111

include order for i2c-amd8111

[Pavel Machek]

Hi!

It seems all linux then all asm is prefered order...
								Pavel

--- clean/drivers/i2c/busses/i2c-amd8111.c	2003-01-05 22:58:27.000000000 +0100
+++ linux-sensors/drivers/i2c/busses/i2c-amd8111.c	2003-01-05 21:13:25.000000000 +0100
@@ -11,7 +11,6 @@
 #include <linux/version.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <asm/io.h>
 #include <linux/kernel.h>
 #include <linux/stddef.h>
 #include <linux/sched.h>
@@ -19,6 +18,7 @@
 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/delay.h>
+#include <asm/io.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR ("Vojtech Pavlik <vojtech@suse.cz>");

-- 
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?

Re: include order for i2c-amd8111

[Rusty Russell]

In message <20030105231349.GA8714@elf.ucw.cz> you write:
> Hi!
> 
> It seems all linux then all asm is prefered order...
> 								Pavel

Yes, but not for any great reason, AFAICT.  I think this comes under
the "too trivial" rule (ie.  I'll accept it from the author, but not
someone else).

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Re: include order for i2c-amd8111

[Vojtech Pavlik]

On Mon, Jan 06, 2003 at 11:40:20AM +1100, Rusty Russell wrote:

> In message <20030105231349.GA8714@elf.ucw.cz> you write:
> > Hi!
> > 
> > It seems all linux then all asm is prefered order...
> > 								Pavel
> 
> Yes, but not for any great reason, AFAICT.  I think this comes under
> the "too trivial" rule (ie.  I'll accept it from the author, but not
> someone else).

The author (me ;) definitely doesn't mind you applying the patch, but
would prefer if the one who pushed the 8111 driver into the kernel
(Pavel) would update it to the version found in lm_sensors 2.7.0 at the
same time.

Thanks.

-- 
Vojtech Pavlik
SuSE Labs

Re: include order for i2c-amd8111

[Pavel Machek]

Hi!

> > > It seems all linux then all asm is prefered order...
> > > 								> > Yes, but not for any great reason, AFAICT.  I think this comes under
> > the "too trivial" rule (ie.  I'll accept it from the author, but not
> > someone else).
> 
> The author (me ;) definitely doesn't mind you applying the patch, but
> would prefer if the one who pushed the 8111 driver into the kernel
> (Pavel) would update it to the version found in lm_sensors 2.7.0 at the
> same time.

Do you think you can mail me that file?

				Pavel

-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...