[PATCH][TRIVIAL] menuconfig color sanity

[PATCH][TRIVIAL] menuconfig color sanity

[jeff gerard]

hi,

using yellow and green text with a "white" background in menuconfig works all
right on console, but it looks like crap under xterm, rxvt, etc. no
matter whose fault that is, the trivial patch below makes things more
readable without any major change in appearance. applies to 2.4 and 2.5.

now you can stop wondering about support for "lug and play", "mateur radio", 
and "elephony" in the linux kernel.

jeff


--- linux-2.5.52.orig/scripts/lxdialog/colors.h	2002-11-10 19:28:02.000000000 -0800
+++ linux-2.5.52/scripts/lxdialog/colors.h	2003-01-08 02:04:07.000000000 -0800
@@ -41 +41 @@
-#define TITLE_FG                     COLOR_YELLOW
+#define TITLE_FG                     COLOR_RED
@@ -93 +93 @@
-#define POSITION_INDICATOR_FG        COLOR_YELLOW
+#define POSITION_INDICATOR_FG        COLOR_RED
@@ -113 +113 @@
-#define TAG_FG                       COLOR_YELLOW
+#define TAG_FG                       COLOR_MAGENTA
@@ -121 +121 @@
-#define TAG_KEY_FG                   COLOR_YELLOW
+#define TAG_KEY_FG                   COLOR_MAGENTA
@@ -137 +137 @@
-#define UARROW_FG                    COLOR_GREEN
+#define UARROW_FG                    COLOR_RED
@@ -141 +141 @@
-#define DARROW_FG                    COLOR_GREEN
+#define DARROW_FG                    COLOR_RED

Re: [PATCH][TRIVIAL] menuconfig color sanity

[Marc-Christian Petersen]

On Wednesday 08 January 2003 11:47, jeff gerard wrote:

Hi Jeff,

> using yellow and green text with a "white" background in menuconfig works
> all right on console, but it looks like crap under xterm, rxvt, etc. no
> matter whose fault that is, the trivial patch below makes things more
> readable without any major change in appearance. applies to 2.4 and 2.5.
> now you can stop wondering about support for "lug and play", "mateur
> radio", and "elephony" in the linux kernel.
huh? I can see Plug and Play, Amateur Radio and Telephony very well also in a 
XTERM etc. I don't know where you have any problems with those colors.

Prolly your xterm etc. are faulty ;)

ciao, Marc

Re: [PATCH][TRIVIAL] menuconfig color sanity

[Dave Jones]

On Wed, Jan 08, 2003 at 12:05:04PM +0100, Marc-Christian Petersen wrote:

 > > using yellow and green text with a "white" background in menuconfig works
 > > all right on console, but it looks like crap under xterm, rxvt, etc. no
 > > matter whose fault that is, the trivial patch below makes things more
 > > readable without any major change in appearance. applies to 2.4 and 2.5.
 > > now you can stop wondering about support for "lug and play", "mateur
 > > radio", and "elephony" in the linux kernel.
 > huh? I can see Plug and Play, Amateur Radio and Telephony very well also in a 
 > XTERM etc. I don't know where you have any problems with those colors.
 > Prolly your xterm etc. are faulty ;)

Different monitors, different graphic cards, different eyes.
All these things offer variation in colour, and yellow text
on a light grey background wasn't exactly a wise choice from
a readability point of view.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk

Re: [PATCH][TRIVIAL] menuconfig color sanity

[Alan Cox]

On Wed, 2003-01-08 at 10:47, jeff gerard wrote:
> hi,
> 
> using yellow and green text with a "white" background in menuconfig works all
> right on console, but it looks like crap under xterm, rxvt, etc. no
> matter whose fault that is, the trivial patch below makes things more
> readable without any major change in appearance. applies to 2.4 and 2.5.
> 
> now you can stop wondering about support for "lug and play", "mateur radio", 
> and "elephony" in the linux kernel.

Try that on a mono monitor before merging it

Re: [PATCH][TRIVIAL] menuconfig color sanity

[Bill Davidsen]

On Wed, 8 Jan 2003, jeff gerard wrote:

> using yellow and green text with a "white" background in menuconfig works all
> right on console, but it looks like crap under xterm, rxvt, etc. no
> matter whose fault that is, the trivial patch below makes things more
> readable without any major change in appearance. applies to 2.4 and 2.5.
> 
> now you can stop wondering about support for "lug and play", "mateur radio", 
> and "elephony" in the linux kernel.

Man, did you look at this on a console? That is uglier than a hedgehog's
asshole! Good idea, poor implementation. Please retry, the default colors
are not as bad on an xterm as the new colors on a console. And with small
memory machines I sure don't build kernels using X! 

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: [PATCH][TRIVIAL] menuconfig color sanity

[Joshua M. Kwan]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

> using yellow and green text with a "white" background in menuconfig works all
> right on console, but it looks like crap under xterm, rxvt, etc. no

It looks fine on Eterm, the only real X terminal :)

Regards
Josh

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH][TRIVIAL] menuconfig color sanity

[John Bradford]

> using yellow and green text with a "white" background in
> menuconfig works all right on console

I have seen the original problem, where the first letter is not
visible in an xterm.

Just add a colour/monochrome toggle, that way people can choose which
they prefer.

John.

Re: [PATCH][TRIVIAL] menuconfig color sanity

[john slee]

On Wed, Jan 08, 2003 at 04:09:02PM +0000, John Bradford wrote:
> > using yellow and green text with a "white" background in
> > menuconfig works all right on console
> 
> I have seen the original problem, where the first letter is not
> visible in an xterm.
> 
> Just add a colour/monochrome toggle, that way people can choose which
> they prefer.

'export TERM=xterm-mono' works fine here

j.

-- 
toyota power: http://indigoid.net/

Re: [PATCH][TRIVIAL] menuconfig color sanityExpires:

[H. Peter Anvin]

Followup to:  <Pine.LNX.3.96.1030108095857.21895A-100000@gatekeeper.tmr.com>
By author:    Bill Davidsen <davidsen@tmr.com>
In newsgroup: linux.dev.kernel
> 
> Man, did you look at this on a console? That is uglier than a hedgehog's
> asshole! Good idea, poor implementation. Please retry, the default colors
> are not as bad on an xterm as the new colors on a console. And with small
> memory machines I sure don't build kernels using X! 
> 

Also, whatever color set is chosen: make sure it works on a
512-character font console, which doesn't have the high-intensity
colors.

	-hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>