* PATCH: module_text_address() defined but not used in module.h
@ 2003-01-07 13:12 Muli Ben-Yehuda
2003-01-08 12:01 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Muli Ben-Yehuda @ 2003-01-07 13:12 UTC (permalink / raw)
To: Rusty Russell; +Cc: Linux-Kernel
module_text_address() is defined as 'static int ...' if modules are
not configured in in module.h, leading to a compiler warning that it
is defined but not used. Make it static inline. Patch against
2.5.54-bk.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.975 -> 1.976
# include/linux/module.h 1.35 -> 1.36
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/01/07 mulix@alhambra.mulix.org 1.976
# fix 'defined but not used' warning
# --------------------------------------------
#
diff -Nru a/include/linux/module.h b/include/linux/module.h
--- a/include/linux/module.h Tue Jan 7 14:18:37 2003
+++ b/include/linux/module.h Tue Jan 7 14:18:37 2003
@@ -328,7 +328,7 @@
}
/* Is this address in a module? */
-static int module_text_address(unsigned long addr)
+static inline int module_text_address(unsigned long addr)
{
return 0;
}
--
Muli Ben-Yehuda
my opinions may seem crazy. But they all make sense. Insane sense, but
sense nontheless. -- Shlomi Fish on #offtopic.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: module_text_address() defined but not used in module.h
2003-01-07 13:12 PATCH: module_text_address() defined but not used in module.h Muli Ben-Yehuda
@ 2003-01-08 12:01 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2003-01-08 12:01 UTC (permalink / raw)
To: Muli Ben-Yehuda; +Cc: Linux-Kernel, torvalds
In message <20030107131243.GJ25540@alhambra> you write:
> module_text_address() is defined as 'static int ...' if modules are
> not configured in in module.h, leading to a compiler warning that it
> is defined but not used. Make it static inline. Patch against
> 2.5.54-bk.
Linus, please apply. Obviously correct, my mistake.
From: Muli Ben-Yehuda <mulix@mulix.org>
diff -Nru a/include/linux/module.h b/include/linux/module.h
--- a/include/linux/module.h Tue Jan 7 14:18:37 2003
+++ b/include/linux/module.h Tue Jan 7 14:18:37 2003
@@ -328,7 +328,7 @@
}
/* Is this address in a module? */
-static int module_text_address(unsigned long addr)
+static inline int module_text_address(unsigned long addr)
{
return 0;
}
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-01-10 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-07 13:12 PATCH: module_text_address() defined but not used in module.h Muli Ben-Yehuda
2003-01-08 12:01 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox