From: William Lee Irwin III <wli@holomorphy.com>
To: Maciej Soltysiak <solt@dns.toxicfilms.tv>
Cc: linux-kernel@vger.kernel.org
Subject: Re: spin_locks without smp.
Date: Fri, 10 Jan 2003 03:45:46 -0800 [thread overview]
Message-ID: <20030110114546.GN23814@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.51.0301101238560.6124@dns.toxicfilms.tv>
On Fri, Jan 10, 2003 at 12:42:34PM +0100, Maciej Soltysiak wrote:
> while browsing through the network drivers about the etherleak issue i
> found that some drivers have:
> #ifdef CONFIG_SMP
> spin_lock_irqsave(...)
> #endif
> and some just:
> spin_lock_irqsave(...)
> or similar.
> Which version should be practiced? i thought spinlocks are irrelevant
> without SMP so we should use #ifdef to shorten the execution path.
Buggy on preempt. Remove the #ifdef
Bill
next prev parent reply other threads:[~2003-01-10 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 11:42 spin_locks without smp Maciej Soltysiak
2003-01-10 11:45 ` William Lee Irwin III [this message]
2003-01-10 11:48 ` William Lee Irwin III
2003-01-10 12:09 ` [PATCH]Re: " Maciej Soltysiak
2003-01-10 13:20 ` Alan Cox
2003-01-10 13:04 ` William Lee Irwin III
2003-01-10 14:19 ` Alan Cox
2003-01-10 13:23 ` Alan Cox
2003-01-10 12:41 ` William Lee Irwin III
2003-01-10 13:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110114546.GN23814@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=solt@dns.toxicfilms.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox