From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] module-init-tools-0.9.7, depmod and GPL-only symbols
Date: Fri, 10 Jan 2003 23:16:49 +0100 [thread overview]
Message-ID: <20030110221649.GA5371@vana> (raw)
Hi Rusty,
I finally got 2.5.56 running with configuration I always used (== almost
everything modular), and I found that module-init-tools-0.9.7 has small
problem with GPL-only symbols: depmod ignores them :-(
As I did not notice any newer version, please apply patch below if you
did not do something simillar already.
Of course you can create better solution, which will actually check
license and so on, but I just decided to leave this task on kernel, as
I believe that we do not want such code duplication between kernel and
module-init-tools.
Thanks,
Petr Vandrovec
diff -ur module-init-tools-0.9.7.src/moduleops_core.c module-init-tools-0.9.7/moduleops_core.c
--- module-init-tools-0.9.7.src/moduleops_core.c 2002-12-26 07:04:42.000000000 +0100
+++ module-init-tools-0.9.7/moduleops_core.c 2003-01-10 23:08:47.000000000 +0100
@@ -30,6 +30,9 @@
ksyms = PERBIT(load_section)(module->mmap, "__ksymtab", &size);
for (i = 0; i < size / sizeof(struct PERBIT(kernel_symbol)); i++)
add_symbol(ksyms[i].name, module);
+ ksyms = PERBIT(load_section)(module->mmap, "__gpl_ksymtab", &size);
+ for (i = 0; i < size / sizeof(struct PERBIT(kernel_symbol)); i++)
+ add_symbol(ksyms[i].name, module);
}
/* Calculate the dependencies for this module */
next reply other threads:[~2003-01-10 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 22:16 Petr Vandrovec [this message]
2003-01-11 7:38 ` [PATCH] module-init-tools-0.9.7, depmod and GPL-only symbols Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110221649.GA5371@vana \
--to=vandrove@vc.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox