From: Adrian Bunk <bunk@fs.tum.de>
To: Tony <kernel@mail.vroon.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3
Date: Sat, 11 Jan 2003 20:19:52 +0100 [thread overview]
Message-ID: <20030111191952.GA21826@fs.tum.de> (raw)
In-Reply-To: <20030111120432.GA28023@sawmill>
On Sat, Jan 11, 2003 at 01:04:32PM +0100, Tony wrote:
> Patch download location:
> http://www.chainsaw.cistron.nl/compile-fixes-irda.patch.gz
>
> The patch I announced several hours ago had issues. I have replaced the
> file on the website with a correct version. If anyone had already
> downloaded the fix, please do so again.
> This fixes the numerous "Concatenation of string literals with
> __FUNCTION__ is depricated" errors in net/irda. This should apply
> cleanly to both a 2.4.21-pre3 and a 2.4.21-pre3-ac3 tree.
>...
Did you try to compile all the files your patch changes?
The following things are obvious typos:
<-- snip -->
...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc
-iwithprefix include -DKBUILD_BASENAME=ircomm_event -c -o
ircomm_event.o ircomm_event.c
ircomm_event.c: In function `ircomm_do_event':
ircomm_event.c:244: warning: too few arguments for format
ircomm_event.c: In function `ircomm_next_state':
ircomm_event.c:260: warning: unknown conversion type character `:' in format
ircomm_event.c:260: warning: int format, pointer arg (arg 3)
ircomm_event.c:260: warning: too many arguments for format
...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc
-iwithprefix include -DKBUILD_BASENAME=irlan_common -c -o
irlan_common.o irlan_common.c
irlan_common.c: In function `irlan_open_data_tsap':
irlan_common.c:479: parse error before `return'
irlan_common.c: In function `irlan_set_multicast_filter':
irlan_common.c:814: warning: too many arguments for format
make[4]: *** [irlan_common.o] Error 1
make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/net/irda/irlan'
<-- snip -->
> Thanks,
> Tony Vroon.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-01-11 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 12:04 [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3 Tony
2003-01-11 19:19 ` Adrian Bunk [this message]
2003-01-12 2:42 ` Tony
2003-01-12 7:24 ` Adrian Bunk
2003-01-12 8:28 ` Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030111191952.GA21826@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=kernel@mail.vroon.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox