public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: rusty@rustcorp.com.au
Cc: akpm@zip.com.au, torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __cacheline_aligned_in_smp?
Date: Sun, 12 Jan 2003 23:35:13 -0800 (PST)	[thread overview]
Message-ID: <20030112.233513.83403887.davem@redhat.com> (raw)
In-Reply-To: <20030113072521.74B842C104@lists.samba.org>

   From: Rusty Russell <rusty@rustcorp.com.au>
   Date: Mon, 13 Jan 2003 18:24:40 +1100

   Dave: Anton suggested you might have a justification for
   __cacheline_aligned doing something on UP?
   
   I think I'd prefer __cacheline_aligned to be the same as
   __cacheline_aligned_in_smp, and have a new __cacheline_aligned_always
   for those who REALLY want it (if any).
   
I think things like oprofile_buffer really want it always.

   -struct tcp_hashinfo __cacheline_aligned tcp_hashinfo = {
   +struct tcp_hashinfo __cacheline_aligned_in_smp tcp_hashinfo = {

This definitely too.

All of the submembers are placed at cacheline boundaries, which
helps even on UP.  If I meant cacheline aligned on SMP I would
have used the corresponding macro :)

  reply	other threads:[~2003-01-13  7:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-13  7:24 [PATCH] __cacheline_aligned_in_smp? Rusty Russell
2003-01-13  7:35 ` David S. Miller [this message]
2003-01-14  1:10   ` Rusty Russell
2003-01-14  6:32     ` David S. Miller
2003-01-15  8:02       ` Rusty Russell
2003-01-16  7:21         ` David S. Miller
2003-01-21 14:09       ` Bill Davidsen
2003-01-13  7:45 ` Jeff Garzik
2003-01-14  2:22   ` Rusty Russell
2003-01-13  9:41 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030112.233513.83403887.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox