[PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[Tony]

Patch download location:
http://www.chainsaw.cistron.nl/compile-fixes-irda.patch.gz

The patch I announced several hours ago had issues. I have replaced the 
file on the website with a correct version. If anyone had already 
downloaded the fix, please do so again.
This fixes the numerous "Concatenation of string literals with 
__FUNCTION__ is depricated" errors in net/irda. This should apply 
cleanly to both a 2.4.21-pre3 and a 2.4.21-pre3-ac3 tree.

GCC 3+ users, please inform me if this patch works for you, so it can be 
submitted.

Thanks,
Tony Vroon.

Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[Adrian Bunk]

On Sat, Jan 11, 2003 at 01:04:32PM +0100, Tony wrote:
> Patch download location:
> http://www.chainsaw.cistron.nl/compile-fixes-irda.patch.gz
> 
> The patch I announced several hours ago had issues. I have replaced the 
> file on the website with a correct version. If anyone had already 
> downloaded the fix, please do so again.
> This fixes the numerous "Concatenation of string literals with 
> __FUNCTION__ is depricated" errors in net/irda. This should apply 
> cleanly to both a 2.4.21-pre3 and a 2.4.21-pre3-ac3 tree.
>...

Did you try to compile all the files your patch changes?

The following things are obvious typos:

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include 
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc 
-iwithprefix include -DKBUILD_BASENAME=ircomm_event  -c -o 
ircomm_event.o ircomm_event.c
ircomm_event.c: In function `ircomm_do_event':
ircomm_event.c:244: warning: too few arguments for format
ircomm_event.c: In function `ircomm_next_state':
ircomm_event.c:260: warning: unknown conversion type character `:' in format
ircomm_event.c:260: warning: int format, pointer arg (arg 3)
ircomm_event.c:260: warning: too many arguments for format
...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include 
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc 
-iwithprefix include -DKBUILD_BASENAME=irlan_common  -c -o 
irlan_common.o irlan_common.c
irlan_common.c: In function `irlan_open_data_tsap':
irlan_common.c:479: parse error before `return'
irlan_common.c: In function `irlan_set_multicast_filter':
irlan_common.c:814: warning: too many arguments for format
make[4]: *** [irlan_common.o] Error 1
make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/net/irda/irlan'

<--  snip  -->

> Thanks,
> Tony Vroon.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[Tony]

Adrian,

You're right, I seem to have missed quite a lot, I have double-checked 
things and updated the patch-file on the website.

URL: http://www.chainsaw.cistron.nl/compile-fixes-irda.patch.gz

How's this one?

Tony

P.S. This one doesn't give any warnings in a compile test.

Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[Adrian Bunk]

On Sun, Jan 12, 2003 at 03:42:25AM +0100, Tony wrote:

> Adrian,
> 
> You're right, I seem to have missed quite a lot, I have double-checked 
> things and updated the patch-file on the website.
>...
> Tony
> 
> P.S. This one doesn't give any warnings in a compile test.

Really???

2.95 still gives me several valid warnings like e.g.:

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include -Wall -Ws
trict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix include 
-DKBUILD_BASENAME=ircomm_tty_attach  -c -o ircomm_tty_attach.o ircomm_tty_attach.c
ircomm_tty_attach.c: In function `ircomm_tty_disconnect_indication':
ircomm_tty_attach.c:360: warning: too few arguments for format
...

<--  snip  -->

In this case the bug in your patch is pretty obvious:

-       IRDA_DEBUG(2, __FUNCTION__ "()\n");
+       IRDA_DEBUG(2, "%s()\n");


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3

[Tony]

Oh *smacks forehead*

The right .options file would help.
You're right, there were 5 bugs left.

Well, this is my third and final try...

http://www.chainsaw.cistron.nl/compile-fixes-irda.patch.gz


Thanks for the testing, and I hope this one works.

Tony.