* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:00 some curiosities on the filesystems layout in kernel config Robert P. J. Day
@ 2003-01-12 6:49 ` Valdis.Kletnieks
2003-01-12 7:01 ` Joshua M. Kwan
2003-02-07 15:23 ` Jan Kara
2003-01-12 6:59 ` Joshua M. Kwan
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Valdis.Kletnieks @ 2003-01-12 6:49 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Sun, 12 Jan 2003 01:00:40 EST, "Robert P. J. Day" <rpjday@mindspring.com> said:
> 2) shouldn't ext3 depend on ext2?
No, because somebody might want ext3 only, and have no intention or
desire to mount a filesystem in ext2 mode. Everything on this laptop
is ext3...
> 3) currently, since quotas are only supported for ext2, ext3 and
> reiserfs, shouldn't quotas depend on at least one of those
> being selected?
Because if we did that, we'd be setting ourselves up for a mess when
fs/xfs/xfs_qm.c eventually shows up - like it already has ;)
Also, from my (possibly incorrect) reading of kernel/sys.c and
fs/quota.c, there won't be a sys_quotactl() in the kernel. As a
result, if you have users who have 'quota -v' in their .login, things
might get interesting. So you might want a config where the quota
system call is there, even if it doesn't do anything incredibly
useful...
--
Valdis Kletnieks
Computer Systems Senior Engineer
Virginia Tech
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:49 ` Valdis.Kletnieks
@ 2003-01-12 7:01 ` Joshua M. Kwan
2003-02-07 15:23 ` Jan Kara
1 sibling, 0 replies; 8+ messages in thread
From: Joshua M. Kwan @ 2003-01-12 7:01 UTC (permalink / raw)
To: rpjday; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
Never mind my patch in this case. I had just hit 'y' to send the email
when I read this! Obviously, I don't know quite enough about how the
kernel works.. I really did think ext3 depended on ext2, since ext3
was simply ext2 + a journal inode.
Oh well. Sorry for the wasted b/w
Regards
Josh
On Sun, Jan 12, 2003 at 01:49:29AM -0500, Valdis.Kletnieks@vt.edu
wrote:
> On Sun, 12 Jan 2003 01:00:40 EST, "Robert P. J. Day" <rpjday@mindspring.com> said:
>
> > 2) shouldn't ext3 depend on ext2?
>
> No, because somebody might want ext3 only, and have no intention or
> desire to mount a filesystem in ext2 mode. Everything on this laptop
> is ext3...
>
> > 3) currently, since quotas are only supported for ext2, ext3 and
> > reiserfs, shouldn't quotas depend on at least one of those
> > being selected?
>
> Because if we did that, we'd be setting ourselves up for a mess when
> fs/xfs/xfs_qm.c eventually shows up - like it already has ;)
>
> Also, from my (possibly incorrect) reading of kernel/sys.c and
> fs/quota.c, there won't be a sys_quotactl() in the kernel. As a
> result, if you have users who have 'quota -v' in their .login, things
> might get interesting. So you might want a config where the quota
> system call is there, even if it doesn't do anything incredibly
> useful...
>
> --
> Valdis Kletnieks
> Computer Systems Senior Engineer
> Virginia Tech
>
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:49 ` Valdis.Kletnieks
2003-01-12 7:01 ` Joshua M. Kwan
@ 2003-02-07 15:23 ` Jan Kara
1 sibling, 0 replies; 8+ messages in thread
From: Jan Kara @ 2003-02-07 15:23 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Robert P. J. Day, Linux kernel mailing list
> On Sun, 12 Jan 2003 01:00:40 EST, "Robert P. J. Day" <rpjday@mindspring.com> said:
>
> > 3) currently, since quotas are only supported for ext2, ext3 and
> > reiserfs, shouldn't quotas depend on at least one of those
> > being selected?
Quotas work also for other filesystems...
> Because if we did that, we'd be setting ourselves up for a mess when
> fs/xfs/xfs_qm.c eventually shows up - like it already has ;)
>
> Also, from my (possibly incorrect) reading of kernel/sys.c and
> fs/quota.c, there won't be a sys_quotactl() in the kernel. As a
> result, if you have users who have 'quota -v' in their .login, things
> might get interesting. So you might want a config where the quota
> system call is there, even if it doesn't do anything incredibly
> useful...
You're right that it won't be in the kernel but in that case 'quota
-v' will just say 'Disk quotas for user test (uid 1000): none' (in case
you haven't any filesystem mounted with usrquota option which is
reasonable if you haven't quotas in kernel).
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:00 some curiosities on the filesystems layout in kernel config Robert P. J. Day
2003-01-12 6:49 ` Valdis.Kletnieks
@ 2003-01-12 6:59 ` Joshua M. Kwan
2003-01-12 7:03 ` Aaron Lehmann
2003-01-13 9:30 ` Werner Almesberger
2003-01-13 12:36 ` Dave Jones
3 siblings, 1 reply; 8+ messages in thread
From: Joshua M. Kwan @ 2003-01-12 6:59 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 880 bytes --]
On Sun, Jan 12, 2003 at 01:00:40AM -0500, Robert P. J. Day wrote:
> 1) where is the USMDOS selection that's listed in the Kconfig file?
> it doesn't appear in the menu
I think you have to select DOS filesystem first and MSDOS fs support,
then it shows up.
>
> 2) shouldn't ext3 depend on ext2?
>
It doesn't currently, but it should.
Patch to 2.4.20 vanilla is attached, it should apply with some fuzz to
patched trees such as -ac and -ck. (I also renamed Second extended fs to
Ext2, a pet peeve of mine..)
> 3) currently, since quotas are only supported for ext2, ext3 and
> reiserfs, shouldn't quotas depend on at least one of those
> being selected?
Not sure whether this is true, I'm not quite sure.
And plus I don't know enough about Config.ins to write that into the
patch (Is it even possible in 2.4's Kconfig?)
Regards
Josh
[-- Attachment #1.2: ext3_dep_ext2.diff --]
[-- Type: text/plain, Size: 959 bytes --]
--- fs/Config.in.orig 2003-01-11 22:53:20.000000000 -0800
+++ fs/Config.in 2003-01-11 22:56:18.000000000 -0800
@@ -24,7 +24,9 @@
dep_tristate 'BFS file system support (EXPERIMENTAL)' CONFIG_BFS_FS $CONFIG_EXPERIMENTAL
-tristate 'Ext3 journalling file system support' CONFIG_EXT3_FS
+tristate 'Ext2 file system support' CONFIG_EXT2_FS
+
+dep_tristate 'Ext3 journalling file system support' CONFIG_EXT3_FS $CONFIG_EXT2_FS
# CONFIG_JBD could be its own option (even modular), but until there are
# other users than ext3, we will simply make it be the same as CONFIG_EXT3_FS
# dep_tristate ' Journal Block Device support (JBD for ext3)' CONFIG_JBD $CONFIG_EXT3_FS
@@ -83,8 +85,6 @@
tristate 'ROM file system support' CONFIG_ROMFS_FS
-tristate 'Second extended fs support' CONFIG_EXT2_FS
-
tristate 'System V/Xenix/V7/Coherent file system support' CONFIG_SYSV_FS
tristate 'UDF file system support (read only)' CONFIG_UDF_FS
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:59 ` Joshua M. Kwan
@ 2003-01-12 7:03 ` Aaron Lehmann
0 siblings, 0 replies; 8+ messages in thread
From: Aaron Lehmann @ 2003-01-12 7:03 UTC (permalink / raw)
To: Joshua M. Kwan; +Cc: Robert P. J. Day, linux-kernel
On Sat, Jan 11, 2003 at 10:59:21PM -0800, Joshua M. Kwan wrote:
> > 3) currently, since quotas are only supported for ext2, ext3 and
> > reiserfs, shouldn't quotas depend on at least one of those
> > being selected?
>
> Not sure whether this is true, I'm not quite sure.
You could compile any of these filesystems as modules.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:00 some curiosities on the filesystems layout in kernel config Robert P. J. Day
2003-01-12 6:49 ` Valdis.Kletnieks
2003-01-12 6:59 ` Joshua M. Kwan
@ 2003-01-13 9:30 ` Werner Almesberger
2003-01-13 12:36 ` Dave Jones
3 siblings, 0 replies; 8+ messages in thread
From: Werner Almesberger @ 2003-01-13 9:30 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list
Robert P. J. Day wrote:
> 3) currently, since quotas are only supported for ext2, ext3 and
> reiserfs, shouldn't quotas depend on at least one of those
> being selected?
The problem with expressing every last dependency is that you'll
end up hiding too much.
A less intrusive approach that doesn't require changes to the
current configuration framework may be to add a section
"Warnings" at the end, under which some pseudo-options would be
enabled if some unusual combinations are found (e.g. CD-ROM
drivers but no ISO9660 file system, PC architecture but no
keyboard, etc.)
- Werner
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina wa@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: some curiosities on the filesystems layout in kernel config
2003-01-12 6:00 some curiosities on the filesystems layout in kernel config Robert P. J. Day
` (2 preceding siblings ...)
2003-01-13 9:30 ` Werner Almesberger
@ 2003-01-13 12:36 ` Dave Jones
3 siblings, 0 replies; 8+ messages in thread
From: Dave Jones @ 2003-01-13 12:36 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list
On Sun, Jan 12, 2003 at 01:00:40AM -0500, Robert P. J. Day wrote:
> 1) where is the USMDOS selection that's listed in the Kconfig file?
> it doesn't appear in the menu
currently broken. this needs fixing at some point for 2.6
> 2) shouldn't ext3 depend on ext2?
nope.
> 3) currently, since quotas are only supported for ext2, ext3 and
> reiserfs, shouldn't quotas depend on at least one of those
> being selected?
Could do, but it's the Kconfig gets messy very quickly when you
have realise that any of those fs's can also be modular.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 8+ messages in thread