From: Adrian Bunk <bunk@fs.tum.de>
To: Tony <kernel@mail.vroon.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3
Date: Sun, 12 Jan 2003 08:24:09 +0100 [thread overview]
Message-ID: <20030112072409.GL21826@fs.tum.de> (raw)
In-Reply-To: <20030112024225.GA28485@sawmill>
On Sun, Jan 12, 2003 at 03:42:25AM +0100, Tony wrote:
> Adrian,
>
> You're right, I seem to have missed quite a lot, I have double-checked
> things and updated the patch-file on the website.
>...
> Tony
>
> P.S. This one doesn't give any warnings in a compile test.
Really???
2.95 still gives me several valid warnings like e.g.:
<-- snip -->
...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include -Wall -Ws
trict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix include
-DKBUILD_BASENAME=ircomm_tty_attach -c -o ircomm_tty_attach.o ircomm_tty_attach.c
ircomm_tty_attach.c: In function `ircomm_tty_disconnect_indication':
ircomm_tty_attach.c:360: warning: too few arguments for format
...
<-- snip -->
In this case the bug in your patch is pretty obvious:
- IRDA_DEBUG(2, __FUNCTION__ "()\n");
+ IRDA_DEBUG(2, "%s()\n");
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-01-12 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 12:04 [PATCH] (revised) fix net/irda warnings for 2.4.21-pre3 Tony
2003-01-11 19:19 ` Adrian Bunk
2003-01-12 2:42 ` Tony
2003-01-12 7:24 ` Adrian Bunk [this message]
2003-01-12 8:28 ` Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030112072409.GL21826@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=kernel@mail.vroon.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox