From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
support@moxa.com.tw
Subject: Re: 2.5.55: static compilation of mxser.c doesn't work
Date: Sun, 12 Jan 2003 10:32:05 +0100 [thread overview]
Message-ID: <20030112093205.GS21826@fs.tum.de> (raw)
In-Reply-To: <1042211563.31612.0.camel@irongate.swansea.linux.org.uk>
On Fri, Jan 10, 2003 at 03:12:43PM +0000, Alan Cox wrote:
> On Fri, 2003-01-10 at 14:03, Adrian Bunk wrote:
> > Hi Arnaldo,
> >
> > the 2.5 Linux kernel contains your patch
> >
> > o mxser: add module_exit/module_init
> > This fixes the compilation problem in 2.5
> >
> > This patch renames mxser_init to mxser_module_init causing a compile
> > error when trying to compile this driver statically into the kernel
> > since mxser_init is still called from drivers/char/tty_io.c.
>
> You should be able to kill the call from tty_io.c
Unfortunately I don't have the hardware to test whether the driver
actually works but the patch below fixes the compilation.
cu
Adrian
--- linux-2.5.56/drivers/char/tty_io.c.old 2003-01-12 10:15:39.000000000 +0100
+++ linux-2.5.56/drivers/char/tty_io.c 2003-01-12 10:16:14.000000000 +0100
@@ -2372,9 +2372,6 @@
rs_8xx_init();
#endif /* CONFIG_8xx */
pty_init();
-#ifdef CONFIG_MOXA_SMARTIO
- mxser_init();
-#endif
#ifdef CONFIG_MOXA_INTELLIO
moxa_init();
#endif
prev parent reply other threads:[~2003-01-12 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 14:03 2.5.55: static compilation of mxser.c doesn't work Adrian Bunk
2003-01-10 15:12 ` Alan Cox
2003-01-12 9:32 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030112093205.GS21826@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox