public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* 2.5.55: static compilation of mxser.c doesn't work
@ 2003-01-10 14:03 Adrian Bunk
  2003-01-10 15:12 ` Alan Cox
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2003-01-10 14:03 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: linux-kernel, support

Hi Arnaldo,

the 2.5 Linux kernel contains your patch

   o mxser: add module_exit/module_init
   This fixes the compilation problem in 2.5

This patch renames mxser_init to mxser_module_init causing a compile 
error when trying to compile this driver statically into the kernel 
since mxser_init is still called from drivers/char/tty_io.c.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 2.5.55: static compilation of mxser.c doesn't work
  2003-01-10 14:03 2.5.55: static compilation of mxser.c doesn't work Adrian Bunk
@ 2003-01-10 15:12 ` Alan Cox
  2003-01-12  9:32   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2003-01-10 15:12 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Arnaldo Carvalho de Melo, Linux Kernel Mailing List, support

On Fri, 2003-01-10 at 14:03, Adrian Bunk wrote:
> Hi Arnaldo,
> 
> the 2.5 Linux kernel contains your patch
> 
>    o mxser: add module_exit/module_init
>    This fixes the compilation problem in 2.5
> 
> This patch renames mxser_init to mxser_module_init causing a compile 
> error when trying to compile this driver statically into the kernel 
> since mxser_init is still called from drivers/char/tty_io.c.

You should be able to kill the call from tty_io.c


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 2.5.55: static compilation of mxser.c doesn't work
  2003-01-10 15:12 ` Alan Cox
@ 2003-01-12  9:32   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2003-01-12  9:32 UTC (permalink / raw)
  To: Alan Cox; +Cc: Arnaldo Carvalho de Melo, Linux Kernel Mailing List, support

On Fri, Jan 10, 2003 at 03:12:43PM +0000, Alan Cox wrote:
> On Fri, 2003-01-10 at 14:03, Adrian Bunk wrote:
> > Hi Arnaldo,
> > 
> > the 2.5 Linux kernel contains your patch
> > 
> >    o mxser: add module_exit/module_init
> >    This fixes the compilation problem in 2.5
> > 
> > This patch renames mxser_init to mxser_module_init causing a compile 
> > error when trying to compile this driver statically into the kernel 
> > since mxser_init is still called from drivers/char/tty_io.c.
> 
> You should be able to kill the call from tty_io.c

Unfortunately I don't have the hardware to test whether the driver 
actually works but the patch below fixes the compilation.

cu
Adrian

--- linux-2.5.56/drivers/char/tty_io.c.old	2003-01-12 10:15:39.000000000 +0100
+++ linux-2.5.56/drivers/char/tty_io.c	2003-01-12 10:16:14.000000000 +0100
@@ -2372,9 +2372,6 @@
 	rs_8xx_init();
 #endif /* CONFIG_8xx */
 	pty_init();
-#ifdef CONFIG_MOXA_SMARTIO
-	mxser_init();
-#endif	
 #ifdef CONFIG_MOXA_INTELLIO
 	moxa_init();
 #endif	

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-01-12  9:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-10 14:03 2.5.55: static compilation of mxser.c doesn't work Adrian Bunk
2003-01-10 15:12 ` Alan Cox
2003-01-12  9:32   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox