From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Rolland <rol@witbe.net>
Cc: linux-kernel@vger.kernel.org, Perex@suze.cz, rol@as2917.net
Subject: Re: [PATCH 2.5.56] Sound core not compiling without /proc support
Date: Sun, 12 Jan 2003 13:56:45 +0100 [thread overview]
Message-ID: <20030112125645.GA996@mars.ravnborg.org> (raw)
In-Reply-To: <008f01c2ba32$3aab6f40$2101a8c0@witbe>
On Sun, Jan 12, 2003 at 01:00:40PM +0100, Paul Rolland wrote:
> Hello,
>
> Here is a quick patch to allow sound support to compile correctly
> when not using /proc support.
You are making all users of functions manipulating /proc condentional.
A simpler approach would be to make the functions that actually
minipulate /proc conditional.
For example snd_info_card_create() could be a noop if CONFIG_PROC_FS
is not defined.
Then you minimize the number of #ifdef's, and they are placed logically
where they belongs.
Furhtermore you make less code conditional which imply that the execution
path - and thus code getting more test - is more similar for the two cases.
Sam
next prev parent reply other threads:[~2003-01-12 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-12 12:00 [PATCH 2.5.56] Sound core not compiling without /proc support Paul Rolland
2003-01-12 12:56 ` Sam Ravnborg [this message]
2003-01-12 13:59 ` Jaroslav Kysela
2003-01-12 14:15 ` Paul Rolland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030112125645.GA996@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Perex@suze.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rol@as2917.net \
--cc=rol@witbe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox