From: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
To: Russell King <rmk@arm.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.56-bug
Date: Mon, 13 Jan 2003 00:49:40 +0100 [thread overview]
Message-ID: <20030113004940.K628@nightmaster.csn.tu-chemnitz.de> (raw)
In-Reply-To: <E18Xh1V-0000R7-00@raistlin.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Sun, Jan 12, 2003 at 12:15:29PM +0000
Hi Russell,
Hi LKML,
On Sun, Jan 12, 2003 at 12:15:29PM +0000, Russell King wrote:
> This patch appears not to be in 2.5.56, but applies cleanly.
>
> This patch moves BUG() and PAGE_BUG() from asm/page.h into asm/bug.h.
While we are at it: BUG() expects the offending task to be killed
so implementations, which just do a printk() there are
non-conforming.
Code paths which contain BUG() or BUG_ON() usally expect this
code-path to end and just threat the opposite condition to be
true.
A conforming implementation is panic(), if faulting is not that
easy in these architectures, but printk() is just plain wrong.
Mind to get a patch on top of your doing exactly this
modification?
Regards
Ingo Oeser
--
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth
next prev parent reply other threads:[~2003-01-13 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-12 12:15 [PATCH] 2.5.56-bug Russell King
2003-01-12 23:49 ` Ingo Oeser [this message]
2003-01-13 9:18 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030113004940.K628@nightmaster.csn.tu-chemnitz.de \
--to=ingo.oeser@informatik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox