Re: 2.5.57 missing isapnp_card_protocol

[Adam Belay <ambx1@neo.rr.com>]

On Tue, Jan 14, 2003 at 02:10:41AM +0300, Ruslan U. Zakirov wrote:
> On Mon, 13 Jan 2003, Jeff Garzik wrote:
> 
> > On Mon, Jan 13, 2003 at 02:09:49PM -0800, Adam J. Richter wrote:
> > > 	Linux-2.5.57 deletes the definition of isapnp_card_protocol
> > > and then adds some references to it.  So, the kernel does not link
> > > if you have enabled ISA PnP support.  I'm not sure whether
> > > isapnp_card_protocol is supposed to be removed or not.
> > 
> > That's the fault of some random driver that hasn't been updated to the
> > new isapnp API yet...
> 
> Hello.
> It's not right.
> It's wrong changes in drivers/pnp/isapnp/core.c and could be fixed with
> changing of two lines:
> drop 
> 	protocol_for_each_card(&isapnp_card_protocol,card)
> and change
> 	protocol_for_each_card(&isapnp_card_protocol,card)
> back to 
> 	protocol_for_each_card(&isapnp_protocol,card) 
> This changes fix compilation problems, but may be it wrong do it in this
> way.
> 
> Best regards.
> 	Ruslan.
> 

Hi Ruslan,

This is indeed a correct fix for this problem.  This bug was not introduced
by me but I appreciate your input.

Thanks,
Adam