From: Andrew Morton <akpm@digeo.com>
To: Zwane Mwaikambo <zwane@holomorphy.com>
Cc: linux-kernel@vger.kernel.org, rml@tech9.net, mingo@elte.hu
Subject: Re: [PATCH][2.5] per-CPU task runqueues
Date: Fri, 17 Jan 2003 01:47:11 -0800 [thread overview]
Message-ID: <20030117014711.6ba112e9.akpm@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0301170415000.24250-100000@montezuma.mastecende.com>
Zwane Mwaikambo <zwane@holomorphy.com> wrote:
>
> This patch simply switches over to per-CPU runqueues as defined by the new
> per cpu api.
> ...
> +static DEFINE_PER_CPU(struct runqueue, runqueues);
These must be initialised to something. gcc-2.91/92 bug. There is a
build-time check for this, but it only detects the mistake if you're using a
compiler which has the bug.
Your patch works here, but I was never able to get this working when the
per-cpu areas were allocated as the CPU's come online, which is something we
kinda should work towards. This patch would need to be reverted if we try to
do that again. Which is a shame, because appreciable amounts of memory would
be saved if nr_cpus < NR_CPUS. scheduler startup is fragile..
I don't think it buys us a lot, really. These structures are so humongous
that we don't get much per-cpuness in accessing them.
next prev parent reply other threads:[~2003-01-17 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-17 9:27 [PATCH][2.5] per-CPU task runqueues Zwane Mwaikambo
2003-01-17 9:47 ` Andrew Morton [this message]
2003-01-17 10:08 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030117014711.6ba112e9.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rml@tech9.net \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox