From: Dave Jones <davej@codemonkey.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: propagating failures down to pci_module_init()
Date: Mon, 20 Jan 2003 16:56:38 +0000 [thread overview]
Message-ID: <20030120165638.GA31809@codemonkey.org.uk> (raw)
In-Reply-To: <20030120165236.GA27972@gtf.org>
On Mon, Jan 20, 2003 at 11:52:36AM -0500, Jeff Garzik wrote:
>
> Nope. Look at pci_module_init code. It propagates pci_register_driver
> return value.
>
> The _real_ problem is that ->probe return value is not propagated back
> to pci_register_driver return value. The reason for this is that you
> may call ->probe many times, and nobody has written the code to collate
> the error returns.
>
> Since one can only sanely return an error code when there was _one_
> device and it failed, you are rather limited in error propagation.
*nod*. I cheated, and used a static global, which seems to get the
desired effect I was after.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
prev parent reply other threads:[~2003-01-20 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-20 15:54 propagating failures down to pci_module_init() Dave Jones
2003-01-20 16:33 ` Christoph Hellwig
2003-01-20 16:52 ` Jeff Garzik
2003-01-20 16:56 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030120165638.GA31809@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox