From: Jamie Lokier <jamie@shareable.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: Re: Minor header bug? MIPS (32-bit) nlink_t sign
Date: Tue, 21 Jan 2003 11:53:08 +0000 [thread overview]
Message-ID: <20030121115308.GA750@bjl1.asuk.net> (raw)
In-Reply-To: <20030121100020.A15008@linux-mips.org>
Ralf Baechle wrote:
> > I assume we are being compatable with Irix? Ralf?
>
> Dunno where the signed int for nlink_t did come from. The original idea
> was to avoid pointless creativity and choose data types to match IRIX
> rsp. the MIPS psABI.
(I've been going through all the <asm-*/*.h> API files, and there is a
lot of duplication, with very small variations. It was with a view to
getting rid of some of the duplication, and making it easy to see what
the _real_ differences are).
MIPS and Sparc are the only architectures that decided to be really
different to all the other Linux archs).
Anyway, I spotted another MIPS suggestion:
asm-mips/siginfo.h:
The comments explain that siginfo_t is IRIX compatible with
extensions. In fact it is not IRIX compatible, now that
siginfo_t._sigchld has an additional _uid field in the middle
of it. So it's compatible for _some_ uses only.
It's obvious that the code author knew of this change (because
_irix_sigchld is there to document it), but didn't change the
comment.
Suggestion:
That comment should be removed or changed as siginfo_t
is not IRIX compatible, at least in this part. And maybe
_irix_sigchld should be removed, along with the comment.
cheers,
-- Jamie
prev parent reply other threads:[~2003-01-21 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-18 3:34 Minor header bug? MIPS (32-bit) nlink_t sign Jamie Lokier
2003-01-21 5:09 ` Stephen Rothwell
2003-01-21 6:18 ` David S. Miller
2003-01-21 9:00 ` Ralf Baechle
2003-01-21 11:53 ` Jamie Lokier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030121115308.GA750@bjl1.asuk.net \
--to=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox