public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Nuno Monteiro <nuno@itsari.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG/PATCH] OSS/sb_mixer.c is broken on 2.5.59
Date: Tue, 21 Jan 2003 15:24:08 +0100	[thread overview]
Message-ID: <20030121142408.GC6870@fs.tum.de> (raw)
In-Reply-To: <20030117161752.GC14939@hobbes.itsari.int>

On Fri, Jan 17, 2003 at 04:17:52PM +0000, Nuno Monteiro wrote:

> Hi,
> 
> I know OSS is not all that supported, but it has been mostly working for 
> the past 2.5 revisions. However, 2.5.59 broke it. Here is the fix, it 
> allows sound/oss/sb_mixer.c to comple again -- I havent booted it yet, 
> but its trivial enough to spot it from a mile away :)

This file is OK in 2.5.59. Could it be that your editor or another 
program you use broke it?

> Regards,
> 
> 
> 		Nuno

> --- linux-2.5.59/sound/oss/sb_mixer.c.orig	Fri Jan 17 15:40:41 2003
> +++ linux-2.5.59/sound/oss/sb_mixer.c	Fri Jan 17 15:40:55 2003
> @@ -45,7 +45,7 @@
>  					SOUND_MASK_TREBLE|SOUND_MASK_SPEAKER )
>  
>  #define SB16_RECORDING_DEVICES		(SOUND_MASK_SYNTH | \
> -					SOUND_MASK_LINE | \ SOUND_MASK_MIC | \
> +					SOUND_MASK_LINE | SOUND_MASK_MIC | \
>  					SOUND_MASK_CD)
>  
>  #define SB16_OUTFILTER_DEVICES		(SOUND_MASK_LINE | SOUND_MASK_MIC | \
> @@ -55,7 +55,7 @@
>  					SOUND_MASK_SPEAKER | \
>  					SOUND_MASK_LINE | SOUND_MASK_MIC | \
>  					SOUND_MASK_CD | SOUND_MASK_IGAIN | \
> -					SOUND_MASK_OGAIN | \ SOUND_MASK_VOLUME | \
> +					SOUND_MASK_OGAIN | SOUND_MASK_VOLUME | \
>  					SOUND_MASK_BASS | SOUND_MASK_TREBLE | \
>  					SOUND_MASK_IMIX)
>  


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2003-01-21 14:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-17 16:17 [BUG/PATCH] OSS/sb_mixer.c is broken on 2.5.59 Nuno Monteiro
2003-01-21 14:24 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030121142408.GC6870@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno@itsari.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox