From: Christoph Hellwig <hch@infradead.org>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@digeo.com>,
Linus Torvalds <torvalds@transmeta.com>,
Wim Coekaerts <Wim.Coekaerts@oracle.com>
Subject: Re: [PATCH (take 2)][2.5] hangcheck-timer
Date: Tue, 21 Jan 2003 18:59:21 +0000 [thread overview]
Message-ID: <20030121185921.A2322@infradead.org> (raw)
In-Reply-To: <20030121184403.GY20972@ca-server1.us.oracle.com>; from Joel.Becker@oracle.com on Tue, Jan 21, 2003 at 10:44:04AM -0800
> +#include <linux/smp_lock.h>
not needed anymore.
> +MODULE_AUTHOR("Joel Becker");
> +MODULE_LICENSE("GPL");
What about a MODULE_DESCRIPTION()?
> +static struct timer_list hangcheck_ticktock = {
> + function: hangcheck_fire,
> +};
Use C99 initializers instead.
> +} /* hangcheck_init() */
These comments are a bit against the usual kernel coding style,
espececially for that short function..
p.s. sorry for not noticing some of the stuff earlier
next prev parent reply other threads:[~2003-01-21 18:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-21 1:19 [PATCH][2.5] hangcheck-timer Joel Becker
2003-01-21 8:11 ` Christoph Hellwig
2003-01-21 17:33 ` Joel Becker
2003-01-21 18:44 ` [PATCH (take 2)][2.5] hangcheck-timer Joel Becker
2003-01-21 18:59 ` Christoph Hellwig [this message]
2003-01-21 19:48 ` Joel Becker
2003-01-21 19:56 ` Christoph Hellwig
2003-01-21 19:04 ` Sam Ravnborg
2003-01-21 12:50 ` [PATCH][2.5] hangcheck-timer Dave Jones
2003-01-21 17:40 ` Joel Becker
2003-01-21 17:42 ` Dave Jones
2003-01-21 18:42 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030121185921.A2322@infradead.org \
--to=hch@infradead.org \
--cc=Joel.Becker@oracle.com \
--cc=Wim.Coekaerts@oracle.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox