From: Jens Axboe <axboe@suse.de>
To: Joerg Schilling <schilling@fokus.fraunhofer.de>,
cdwrite@other.debian.org, greg@ulima.unil.ch,
linux-kernel@vger.kernel.org
Subject: Re: Can't burn DVD under 2.5.59 with ide-cd
Date: Wed, 22 Jan 2003 09:35:30 +0100 [thread overview]
Message-ID: <20030122083530.GA20780@suse.de> (raw)
In-Reply-To: <200301220823.h0M8NG2o022692@burner.fokus.gmd.de>
On Wed, Jan 22 2003, Joerg Schilling wrote:
> >From axboe@suse.de Wed Jan 22 09:06:12 2003
>
> >> >BURN-Free is ON.
> >> >Starting new track at sector: 0
> >> >Track 01: 4 of 4001 MB written (fifo 96%) 16.1x.cdrecord-prodvd: Success. write_g1: scsi sendcmd: no error
> >> >CDB: 2A 00 00 00 08 B8 00 00 1F 00
> >> >status: 0x1 (GOOD STATUS)
> >> >resid: 63488
> >> >cmd finished after 0.008s timeout 100s
> >>
> >> I can't tell you what happened because the kernel is broken :-(
> >>
> >> If you fix the kernel, you will get a readble error message,
>
> >How helpful. How about saying what's broken instead and I'd be happy to
> >fix it.
>
> I thought it's obvious: It is most likely a problem caused by the broken
> bit #defines in the Linux kernel for the SCSI status byte. I assume that
> status should be 0x02 instead of 0x01. In addition, I would guess that
Sounds plausible. Patch attached. Anyone care to expand on _why_ these
status bytes are shifted one bit?
===== drivers/ide/ide-cd.c 1.35 vs edited =====
--- 1.35/drivers/ide/ide-cd.c Thu Nov 21 22:56:59 2002
+++ edited/drivers/ide/ide-cd.c Wed Jan 22 09:34:28 2003
@@ -706,7 +706,7 @@
* scsi status byte
*/
if ((rq->flags & REQ_BLOCK_PC) && !rq->errors)
- rq->errors = CHECK_CONDITION;
+ rq->errors = CHECK_CONDITION << 1;
/* Check for tray open. */
if (sense_key == NOT_READY) {
--
Jens Axboe
next prev parent reply other threads:[~2003-01-22 8:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-22 8:23 Can't burn DVD under 2.5.59 with ide-cd Joerg Schilling
2003-01-22 8:35 ` Jens Axboe [this message]
2003-01-22 9:47 ` Gregoire Favre
2003-01-22 12:57 ` Bob_Tracy(0000)
2003-01-23 17:51 ` Gregoire Favre
2003-01-22 12:00 ` Andre Hedrick
2003-01-22 18:13 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2003-01-23 17:52 Joerg Schilling
2003-01-23 18:01 ` Gregoire Favre
2003-01-23 18:06 ` Jens Axboe
2003-01-23 18:10 ` Jens Axboe
2003-01-23 18:55 ` Gregoire Favre
2003-01-23 19:07 ` Jens Axboe
2003-01-23 19:21 ` Gregoire Favre
2003-01-23 21:18 ` Jens Axboe
2003-01-23 21:54 ` Gregoire Favre
2003-01-24 7:55 ` Jens Axboe
2003-01-24 9:10 ` Henning P. Schmiedehausen
2003-01-24 9:26 ` Jens Axboe
2003-01-25 14:25 ` Gregoire Favre
2003-01-26 16:23 ` Jens Axboe
2003-01-26 16:38 ` Gregoire Favre
2003-01-23 18:02 ` Jens Axboe
2003-01-22 15:38 Joerg Schilling
2003-01-22 1:09 Joerg Schilling
2003-01-22 8:05 ` Jens Axboe
2003-01-21 22:07 Gregoire Favre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030122083530.GA20780@suse.de \
--to=axboe@suse.de \
--cc=cdwrite@other.debian.org \
--cc=greg@ulima.unil.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=schilling@fokus.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox