remove EXT2_MAX_BLOCK_SIZE

remove EXT2_MAX_BLOCK_SIZE

[William Lee Irwin III]

Remove 100% unused EXT2_MAX_BLOCK_SIZE.

 ext2_fs.h |    1 -
 1 files changed, 1 deletion(-)


diff -urpN cleanup-2.5.59-3/include/linux/ext2_fs.h cleanup-2.5.59-4/include/linux/ext2_fs.h
--- cleanup-2.5.59-3/include/linux/ext2_fs.h	2003-01-16 18:21:39.000000000 -0800
+++ cleanup-2.5.59-4/include/linux/ext2_fs.h	2003-01-22 12:26:00.000000000 -0800
@@ -90,7 +90,6 @@ static inline struct ext2_sb_info *EXT2_
  * Macro-instructions used to manage several block sizes
  */
 #define EXT2_MIN_BLOCK_SIZE		1024
-#define	EXT2_MAX_BLOCK_SIZE		4096
 #define EXT2_MIN_BLOCK_LOG_SIZE		  10
 #ifdef __KERNEL__
 # define EXT2_BLOCK_SIZE(s)		((s)->s_blocksize)

Re: remove EXT2_MAX_BLOCK_SIZE

[Andreas Dilger]

On Jan 22, 2003  12:28 -0800, William Lee Irwin III wrote:
> Remove 100% unused EXT2_MAX_BLOCK_SIZE.
> 
> diff -urpN cleanup-2.5.59-3/include/linux/ext2_fs.h cleanup-2.5.59-4/include/linux/ext2_fs.h
> --- cleanup-2.5.59-3/include/linux/ext2_fs.h	2003-01-16 18:21:39.000000000 -0800
> +++ cleanup-2.5.59-4/include/linux/ext2_fs.h	2003-01-22 12:26:00.000000000 -0800
> @@ -90,7 +90,6 @@ static inline struct ext2_sb_info *EXT2_
>   * Macro-instructions used to manage several block sizes
>   */
>  #define EXT2_MIN_BLOCK_SIZE		1024
> -#define	EXT2_MAX_BLOCK_SIZE		4096
>  #define EXT2_MIN_BLOCK_LOG_SIZE		  10
>  #ifdef __KERNEL__
>  # define EXT2_BLOCK_SIZE(s)		((s)->s_blocksize)

Actually, the correct fix is to check in ext2_read_super() whether the
blocksize is larger than EXT2_MAX_BLOCK_SIZE like ext3 does, and maybe
even fix up the code drift between that part of ext2_read_super() and
ext3_read_super()...

Both ext2 and ext3 will in theory support a blocksize up to PAGE_SIZE,
but nobody with access to a > 4kB PAGE_SIZE system has bothered to test
whether it works, so EXT[23]_MAX_BLOCK_SIZE has not been increased.
Any e2fsprogs from the last year or so will support larger blocksizes,
but it has never been tested AFAIK.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

Re: remove EXT2_MAX_BLOCK_SIZE

[William Lee Irwin III]

On Wed, Jan 22, 2003 at 02:12:42PM -0700, Andreas Dilger wrote:
> Actually, the correct fix is to check in ext2_read_super() whether the
> blocksize is larger than EXT2_MAX_BLOCK_SIZE like ext3 does, and maybe
> even fix up the code drift between that part of ext2_read_super() and
> ext3_read_super()...
> Both ext2 and ext3 will in theory support a blocksize up to PAGE_SIZE,
> but nobody with access to a > 4kB PAGE_SIZE system has bothered to test
> whether it works, so EXT[23]_MAX_BLOCK_SIZE has not been increased.
> Any e2fsprogs from the last year or so will support larger blocksizes,
> but it has never been tested AFAIK.

Block sizes > 4K should be trivially testable on IA64. ISTR bcrl having
patches to increase PAGE_CACHE_SIZE independently of PAGE_SIZE and
repair ext2's assumptions, so they should also be testable that way.


-- wli