From: "David S. Miller" <davem@redhat.com>
To: jgarzik@pobox.com
Cc: ink@jurassic.park.msu.ru, willy@debian.org,
linux-kernel@vger.kernel.org, Jeff.Wiedemeier@hp.com
Subject: Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state
Date: Fri, 24 Jan 2003 11:34:51 -0800 (PST) [thread overview]
Message-ID: <20030124.113451.108343849.davem@redhat.com> (raw)
In-Reply-To: <20030124193135.GA30884@gtf.org>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Fri, 24 Jan 2003 14:31:35 -0500
So, the above patch is probably the wrong thing to do. I'll need to
check to be sure, but I think that h/w reset clears MSGINT_MODE_ENABLE,
so we wouldn't want to be randomly enabling it when it is purposefully
disabled.
DaveM/Jeff, corrections?
You're right Jeff, I hadn't noticed the forced enabling of MSI, that
is totally wrong.
next prev parent reply other threads:[~2003-01-24 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-24 18:27 [patch 2.5] tg3.c: pci_{save,restore}_extended_state Ivan Kokshaysky
2003-01-24 19:31 ` Jeff Garzik
2003-01-24 19:34 ` David S. Miller [this message]
2003-01-24 20:00 ` Wiedemeier, Jeff
2003-01-24 19:53 ` David S. Miller
2003-01-24 20:04 ` Wiedemeier, Jeff
2003-01-24 20:05 ` Jeff Garzik
2003-01-24 20:24 ` Wiedemeier, Jeff
2003-01-24 20:34 ` Jeff Garzik
2003-01-24 20:46 ` Wiedemeier, Jeff
2003-01-24 20:51 ` David S. Miller
2003-01-24 21:33 ` Wiedemeier, Jeff
2003-01-24 21:34 ` David S. Miller
2003-01-24 22:41 ` Ivan Kokshaysky
2003-01-24 22:32 ` David S. Miller
2003-01-24 22:51 ` Jeff Garzik
2003-01-25 0:33 ` Wiedemeier, Jeff
2003-01-25 1:42 ` David S. Miller
2003-01-24 22:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030124.113451.108343849.davem@redhat.com \
--to=davem@redhat.com \
--cc=Jeff.Wiedemeier@hp.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox