public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Jeff.Wiedemeier@hp.com
Cc: jgarzik@pobox.com, ink@jurassic.park.msu.ru, willy@debian.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state
Date: Fri, 24 Jan 2003 13:34:34 -0800 (PST)	[thread overview]
Message-ID: <20030124.133434.66251483.davem@redhat.com> (raw)
In-Reply-To: <20030124163341.A4366@dsnt25.mro.cpqcorp.net>

   From: "Wiedemeier, Jeff" <Jeff.Wiedemeier@hp.com>
   Date: Fri, 24 Jan 2003 16:33:41 -0500
   
   If it needs to be made a driver decision, there needs to be some way to
   communicate the correct vector information for whichever option the
   driver is using (if there already is and I missed it, please let me
   know). Otherwise, it seems that trying to match spec behavior given the
   hardware design or disabling MSI at config time for these devices (such
   as through quirks) are the options.

Right, the whole issue is that we're generally MSI ignorant in our PCI
layer right now.  And you're trying to make use of MSI on some
platform :-)

So because the driver has no way to ask the platform "are you going
to use MSI for this device?" there is no way for tg3 to portably
deal with this issue.

That being said, why don't we add "pci_using_msi(pdev)" to asm/pci.h?
Once we have that, tg3.c can then go and set the tg3 specific MSI
enable bit to match whatever pci_using_msi(pdev) returns.  This, plus
the extended state save/restore, should solve all the problems.


  reply	other threads:[~2003-01-24 21:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-24 18:27 [patch 2.5] tg3.c: pci_{save,restore}_extended_state Ivan Kokshaysky
2003-01-24 19:31 ` Jeff Garzik
2003-01-24 19:34   ` David S. Miller
2003-01-24 20:00   ` Wiedemeier, Jeff
2003-01-24 19:53     ` David S. Miller
2003-01-24 20:04       ` Wiedemeier, Jeff
2003-01-24 20:05     ` Jeff Garzik
2003-01-24 20:24       ` Wiedemeier, Jeff
2003-01-24 20:34         ` Jeff Garzik
2003-01-24 20:46           ` Wiedemeier, Jeff
2003-01-24 20:51             ` David S. Miller
2003-01-24 21:33               ` Wiedemeier, Jeff
2003-01-24 21:34                 ` David S. Miller [this message]
2003-01-24 22:41                   ` Ivan Kokshaysky
2003-01-24 22:32                     ` David S. Miller
2003-01-24 22:51                       ` Jeff Garzik
2003-01-25  0:33                       ` Wiedemeier, Jeff
2003-01-25  1:42                         ` David S. Miller
2003-01-24 22:56                 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030124.133434.66251483.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=Jeff.Wiedemeier@hp.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox