From: Jeff Garzik <jgarzik@pobox.com>
To: "Wiedemeier, Jeff" <Jeff.Wiedemeier@hp.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
"David S. Miller" <davem@redhat.com>,
willy@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state
Date: Fri, 24 Jan 2003 15:05:38 -0500 [thread overview]
Message-ID: <20030124200538.GB30884@gtf.org> (raw)
In-Reply-To: <20030124150006.A2882@dsnt25.mro.cpqcorp.net>
On Fri, Jan 24, 2003 at 03:00:06PM -0500, Wiedemeier, Jeff wrote:
> The problem is that if the chip is configured for MSI (through config
> space) and the platform's irq mapping code therefore filled in
> pci_dev->irq with an appropriate vector for the MSI interrupt the chip
> is assigned instead of the LSI interrupt it may also be assigned, then
> unless MSGINT_MODE matches PCI_MSI_FLAGS_ENABLE, the driver will grab
> wrong interrupt.
That implies we should be disabling PCI_MSI_FLAGS_ENABLE when we first
initialize each board, if hardware reset does not automatically do that
for us...
Jeff
next prev parent reply other threads:[~2003-01-24 19:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-24 18:27 [patch 2.5] tg3.c: pci_{save,restore}_extended_state Ivan Kokshaysky
2003-01-24 19:31 ` Jeff Garzik
2003-01-24 19:34 ` David S. Miller
2003-01-24 20:00 ` Wiedemeier, Jeff
2003-01-24 19:53 ` David S. Miller
2003-01-24 20:04 ` Wiedemeier, Jeff
2003-01-24 20:05 ` Jeff Garzik [this message]
2003-01-24 20:24 ` Wiedemeier, Jeff
2003-01-24 20:34 ` Jeff Garzik
2003-01-24 20:46 ` Wiedemeier, Jeff
2003-01-24 20:51 ` David S. Miller
2003-01-24 21:33 ` Wiedemeier, Jeff
2003-01-24 21:34 ` David S. Miller
2003-01-24 22:41 ` Ivan Kokshaysky
2003-01-24 22:32 ` David S. Miller
2003-01-24 22:51 ` Jeff Garzik
2003-01-25 0:33 ` Wiedemeier, Jeff
2003-01-25 1:42 ` David S. Miller
2003-01-24 22:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030124200538.GB30884@gtf.org \
--to=jgarzik@pobox.com \
--cc=Jeff.Wiedemeier@hp.com \
--cc=davem@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox