Re: [patch 2.5] tg3.c: pci_{save,restore}_extended_state

[Ivan Kokshaysky <ink@jurassic.park.msu.ru>]

On Fri, Jan 24, 2003 at 01:34:34PM -0800, David S. Miller wrote:
> Right, the whole issue is that we're generally MSI ignorant in our PCI
> layer right now.  And you're trying to make use of MSI on some
> platform :-)

Right. Alpha is way ahead, as usual. ;-)

> So because the driver has no way to ask the platform "are you going
> to use MSI for this device?" there is no way for tg3 to portably
> deal with this issue.
> 
> That being said, why don't we add "pci_using_msi(pdev)" to asm/pci.h?
> Once we have that, tg3.c can then go and set the tg3 specific MSI
> enable bit to match whatever pci_using_msi(pdev) returns.  This, plus
> the extended state save/restore, should solve all the problems.

I don't understand the issue, really. The config register says:
"MSIs are enabled". Which means: "My platform is *really* going to
use MSI". Why do you want to ignore that?
In the case when firmware has MSI enabled by mistake and it's known
that this platform cannot support MSI, we'll have a quirk that
fixes the config register. No?

Ivan.