public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@namesys.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, hch@lst.de, jack@suse.cz, mason@suse.com
Subject: Re: ext2 FS corruption with 2.5.59.
Date: Sun, 26 Jan 2003 12:25:50 +0300	[thread overview]
Message-ID: <20030126122550.A17142@namesys.com> (raw)
In-Reply-To: <20030125151301.18b70ef3.akpm@digeo.com>

Hello!

On Sat, Jan 25, 2003 at 03:13:01PM -0800, Andrew Morton wrote:
> > Also I think that taking BKL just to update some inode accounting stuff is kind of expensive,
> > so certainly better solution must exist.
> However, in reviewing it, I don't see exactly what's going on.  Because only
> one process is accessing the stat information of the fsx inode anyway?

Well, I came to conclusion that we have fsx doing truncate racing
with fsstress doing sync->iput->ext2_discard_prealloc()

> Yes, we need to rub out that i_bytes/i_blocks thing, replace it with an
> atomically updated loff_t, etc.  But I'd like to understand what the exact
> failure is first.  It _seems_ that stat has somehow seen a >4G value of
> stat->size, but how can this happen???

It's just become negative as we discarding prealloc twice.

Bye,
    Oleg

  reply	other threads:[~2003-01-26  9:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23 12:38 ext2 FS corruption with 2.5.59 Oleg Drokin
2003-01-23 14:09 ` Hugh Dickins
2003-01-23 14:26   ` Oleg Drokin
2003-01-23 14:39     ` Oleg Drokin
2003-01-24 10:32 ` Andrew Morton
2003-01-24 12:39   ` Oleg Drokin
2003-01-25  6:53     ` Andrew Morton
2003-01-25 12:36       ` Oleg Drokin
2003-01-25 23:13         ` Andrew Morton
2003-01-26  9:25           ` Oleg Drokin [this message]
2003-01-26  3:04         ` Andrew Morton
2003-01-26  3:28           ` William Lee Irwin III
2003-01-26  3:46             ` Andrew Morton
2003-01-26  4:14               ` William Lee Irwin III
2003-01-26  5:10                 ` Andrew Morton
2003-01-27 22:59                   ` Stephen Hemminger
2003-01-27 23:59                     ` William Lee Irwin III
2003-01-26 11:11           ` Anton Blanchard
2003-01-26 11:23             ` Andrew Morton
2003-01-28 13:50   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030126122550.A17142@namesys.com \
    --to=green@namesys.com \
    --cc=akpm@digeo.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox