public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Gregoire Favre <greg@ulima.unil.ch>
Cc: "Henning P. Schmiedehausen" <hps@intermeta.de>,
	linux-kernel@vger.kernel.org
Subject: Re: Can't burn DVD under 2.5.59 with ide-cd
Date: Sun, 26 Jan 2003 17:23:48 +0100	[thread overview]
Message-ID: <20030126162348.GP889@suse.de> (raw)
In-Reply-To: <20030125142547.GB18989@ulima.unil.ch>

On Sat, Jan 25 2003, Gregoire Favre wrote:
> On Fri, Jan 24, 2003 at 10:26:16AM +0100, Jens Axboe wrote:
> 
> > The interesting part is whether failed has a sense attached, and if so
> > what length.
> > > 
> > > >                cdrom_analyze_sense_data(drive, failed, sense);
> > 
> > To avoid confusion, I made the patch. Would have been easier to do in
> > the first place it seems :)
> > 
> > ===== drivers/ide/ide-cd.c 1.35 vs edited =====
> > --- 1.35/drivers/ide/ide-cd.c	Thu Nov 21 22:56:59 2002
> > +++ edited/drivers/ide/ide-cd.c	Fri Jan 24 10:25:53 2003
> > @@ -649,6 +649,8 @@
> >  		struct cdrom_info *info = drive->driver_data;
> >  		void *sense = &info->sense_data;
> >  		
> > +		if (failed && blk_pc_request(failed))
> > +			printk("%s: failed, sense %p, len=%d\n", __FUNCTION__, failed->sense, failed->sense_len);
> >  		if (failed && failed->sense)
> >  			sense = failed->sense;
> 
> Hello,
> 
> sorry I didn't understood that I was supposed to do this...
> I have recompiled with your patch, and here the result of dmesg:
> 
> cdrom_end_request: failed, sense ce68de20, len=0
> cdrom_end_request: failed, sense ce68de20, len=0

Thanks, this is the info I wanted. The sense info has not been read from
the drive, it seems.

-- 
Jens Axboe


  reply	other threads:[~2003-01-26 16:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23 17:52 Can't burn DVD under 2.5.59 with ide-cd Joerg Schilling
2003-01-23 18:01 ` Gregoire Favre
2003-01-23 18:06   ` Jens Axboe
2003-01-23 18:10     ` Jens Axboe
2003-01-23 18:55       ` Gregoire Favre
2003-01-23 19:07         ` Jens Axboe
2003-01-23 19:21           ` Gregoire Favre
2003-01-23 21:18             ` Jens Axboe
2003-01-23 21:54               ` Gregoire Favre
2003-01-24  7:55                 ` Jens Axboe
2003-01-24  9:10     ` Henning P. Schmiedehausen
2003-01-24  9:26       ` Jens Axboe
2003-01-25 14:25         ` Gregoire Favre
2003-01-26 16:23           ` Jens Axboe [this message]
2003-01-26 16:38             ` Gregoire Favre
2003-01-23 18:02 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2003-01-22 15:38 Joerg Schilling
2003-01-22  8:23 Joerg Schilling
2003-01-22  8:35 ` Jens Axboe
2003-01-22  9:47   ` Gregoire Favre
2003-01-22 12:57   ` Bob_Tracy(0000)
2003-01-23 17:51   ` Gregoire Favre
2003-01-22 12:00 ` Andre Hedrick
2003-01-22 18:13 ` William Lee Irwin III
2003-01-22  1:09 Joerg Schilling
2003-01-22  8:05 ` Jens Axboe
2003-01-21 22:07 Gregoire Favre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030126162348.GP889@suse.de \
    --to=axboe@suse.de \
    --cc=greg@ulima.unil.ch \
    --cc=hps@intermeta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox