public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Zander <zander@minion.de>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: Christian Zander <zander@minion.de>,
	Mark Fasheh <mark.fasheh@oracle.com>,
	Thomas Schlichter <schlicht@uni-mannheim.de>,
	"Randy.Dunlap" <rddunlap@osdl.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: no version magic, tainting kernel.
Date: Mon, 27 Jan 2003 00:12:32 +0100	[thread overview]
Message-ID: <20030126231232.GE394@kugai> (raw)
In-Reply-To: <Pine.LNX.4.44.0301261524570.15900-100000@chaos.physics.uiowa.edu>

On Sun, Jan 26, 2003 at 03:46:30PM -0600, Kai Germaschewski wrote:
> 
> That's not true. For example, how would an old external build system
> magically starting to compile modules as .ko without updating? How
> would it have added -DKBUILD_BASENAME and -DKBUILD_MODNAME, which
> are required by the new module code. And, how did they avoid subtle
> breakage like not giving the same switches on the command line?
> (This list goes on...)
> 

I hear you, but these changes were easy enough to adapt to.

> Also, it's not true that they've been broken deliberately. As work
> progresses, breakage occurs, that's just a fact of live. However,
> introduction of __vermagic was not introduced in order to make live
> for maintainers of external modules harder, it was introduced since
> loading modules compiled with gcc3 into a kernel compiled with gcc2
> caused crashes for people.
> 

Well, in this specific case an alternate solution was proposed that
would have solved any of the potential problems pointed out.

> Okay, you have a point here, there's still a bug. vermagic.o will be
> rebuilt when the version changes or any of the recorded config
> options change, but it doesn't pick up changes in the compiler
> version, if the new gcc has the same name.
> 
> That's a bug for internal use as well, the patch below fixes it.
> 

Fair enough.

> o One thing I do not understand at all: What is the problem with
> using the internal build system? It makes maintainance of external
> modules much easier than keeping track of what happens in the kernel
> and patching a private solution all the time.
> 

My primary concern is compatibility with those kernels that do not use
kbuild or a different version of it. Ideally, one would want to use
the same build system for all possible kernel versions rather than use
Makefiles that attempt to pick the best choice. I guess I'm convinced
that the latter is the "best" solution to dealing with this problem at
this point, and I can live with that.

What's the most reliable way to tell if kbuild is available, and what
differences among kbuild versions will one have to look out for?

>   I don't even see any license issues, first of all you don't even
>   distribute it, the user who's building the module will already
>   have it along with his kernel source. And if you're using it to
>   compile (possibly binary) modules you want to distribute, you can
>   just use it just like gcc without any further obligations, so no
>   problem there either. (IANAL, of course)
> 

I don't see any problems with kbuild, I was referring to vermagic.c.

-- 
christian zander
zander@minion.de

  reply	other threads:[~2003-01-26 22:06 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23 13:59 no version magic, tainting kernel Thomas Schlichter
2003-01-23 16:29 ` Randy.Dunlap
2003-01-23 16:52 ` Sam Ravnborg
2003-01-23 17:32   ` Thomas Schlichter
2003-01-23 18:22     ` Sam Ravnborg
2003-01-23 19:35       ` Mark Fasheh
2003-01-26 13:29         ` Christian Zander
2003-01-26 13:33           ` Keith Owens
2003-01-26 18:02             ` Kai Germaschewski
2003-01-26 17:51           ` Kai Germaschewski
2003-01-26 21:57             ` Christian Zander
2003-01-26 21:46               ` Kai Germaschewski
2003-01-26 23:12                 ` Christian Zander [this message]
2003-01-26 22:55                   ` David Woodhouse
2003-01-27  0:07                     ` Christian Zander
2003-01-26 23:16                       ` David Woodhouse
2003-01-27  0:24                         ` Christian Zander
2003-01-27 16:25                         ` Kai Germaschewski
2003-01-27 16:29                           ` David Woodhouse
2003-01-27 16:39                             ` Kai Germaschewski
2003-01-27  6:17                 ` Petr Vandrovec
2003-01-27  9:02                   ` David Woodhouse
2003-01-27  9:24                     ` Petr Vandrovec
2003-01-27 17:59                 ` Joel Becker
2003-01-27 18:31                   ` Kai Germaschewski
2003-01-27 22:15                     ` Joel Becker
2003-01-27 23:08                       ` Kai Germaschewski
2003-01-27 23:37                         ` Joel Becker
2003-01-28 15:43                       ` David Woodhouse
2003-01-28 17:03                         ` Joel Becker
2003-01-26 22:23               ` Christian Zander
2003-01-26 17:43         ` Kai Germaschewski
2003-01-26 22:08           ` Christian Zander
2003-01-26 21:29             ` Sam Ravnborg
2003-01-26 23:03               ` Christian Zander
2003-01-26 21:40             ` David Woodhouse
2003-01-26 23:28               ` Christian Zander
2003-01-26 22:46                 ` David Woodhouse
2003-01-26 23:56                   ` Christian Zander
2003-01-26 23:04                     ` David Woodhouse
2003-01-28  1:58         ` Rusty Russell
2003-01-28 19:10           ` Mark Fasheh
2003-01-28 19:17             ` Kai Germaschewski
2003-01-27 18:52 ` Jerry Cooperstein
2003-01-27 19:12   ` Sam Ravnborg
2003-01-27 19:35     ` Jerry Cooperstein
2003-01-27 19:54   ` Gerd Knorr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030126231232.GE394@kugai \
    --to=zander@minion.de \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --cc=rddunlap@osdl.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=schlicht@uni-mannheim.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox